summaryrefslogtreecommitdiffstats
path: root/Lib/importlib
diff options
context:
space:
mode:
authorBrett Cannon <brett@python.org>2016-02-21 02:35:41 (GMT)
committerBrett Cannon <brett@python.org>2016-02-21 02:35:41 (GMT)
commit558823a0cf7834cb8bc45123604008e33b4e69e2 (patch)
tree9f381020ea9dca25831e6fcea2aa63d76b9189e9 /Lib/importlib
parent4f38cb41fe022c94bb5569c72d8b48020d8c13d4 (diff)
downloadcpython-558823a0cf7834cb8bc45123604008e33b4e69e2.zip
cpython-558823a0cf7834cb8bc45123604008e33b4e69e2.tar.gz
cpython-558823a0cf7834cb8bc45123604008e33b4e69e2.tar.bz2
Issue #26186: Remove an invalid type check in
importlib.util.LazyLoader. The class was checking its argument as to whether its implementation of create_module() came directly from importlib.abc.Loader. The problem is that the classes coming from imoprtlib.machinery do not directly inherit from the ABC as they come from _frozen_importlib. Because the documentation has always said that create_module() was ignored, the check has simply been removed.
Diffstat (limited to 'Lib/importlib')
-rw-r--r--Lib/importlib/abc.py1
-rw-r--r--Lib/importlib/util.py5
2 files changed, 0 insertions, 6 deletions
diff --git a/Lib/importlib/abc.py b/Lib/importlib/abc.py
index 11af22d..daff681 100644
--- a/Lib/importlib/abc.py
+++ b/Lib/importlib/abc.py
@@ -4,7 +4,6 @@ from . import _bootstrap_external
from . import machinery
try:
import _frozen_importlib
-# import _frozen_importlib_external
except ImportError as exc:
if exc.name != '_frozen_importlib':
raise
diff --git a/Lib/importlib/util.py b/Lib/importlib/util.py
index 1dbff26..4525b3f 100644
--- a/Lib/importlib/util.py
+++ b/Lib/importlib/util.py
@@ -263,11 +263,6 @@ class LazyLoader(abc.Loader):
def __check_eager_loader(loader):
if not hasattr(loader, 'exec_module'):
raise TypeError('loader must define exec_module()')
- elif hasattr(loader.__class__, 'create_module'):
- if abc.Loader.create_module != loader.__class__.create_module:
- # Only care if create_module() is overridden in a subclass of
- # importlib.abc.Loader.
- raise TypeError('loader cannot define create_module()')
@classmethod
def factory(cls, loader):