diff options
| author | Dong-hee Na <donghee.na92@gmail.com> | 2020-01-11 17:39:15 (GMT) |
|---|---|---|
| committer | Victor Stinner <vstinner@python.org> | 2020-01-11 17:39:15 (GMT) |
| commit | 1b335ae281631a12201fdec29b3c55d97166fc06 (patch) | |
| tree | e067d97221416877e47fad06e6a14cded864b468 /Lib/nntplib.py | |
| parent | 136735c1a2efb320e4cbb64b40f1191228745b39 (diff) | |
| download | cpython-1b335ae281631a12201fdec29b3c55d97166fc06.zip cpython-1b335ae281631a12201fdec29b3c55d97166fc06.tar.gz cpython-1b335ae281631a12201fdec29b3c55d97166fc06.tar.bz2 | |
bpo-39259: nntplib.NNTP/NNTP_SSL now reject timeout = 0 (GH-17936)
nntplib.NNTP and nntplib.NNTP_SSL now raise a ValueError
if the given timeout for their constructor is zero to
prevent the creation of a non-blocking socket.
Diffstat (limited to 'Lib/nntplib.py')
| -rw-r--r-- | Lib/nntplib.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/Lib/nntplib.py b/Lib/nntplib.py index 0ab5185..8951203 100644 --- a/Lib/nntplib.py +++ b/Lib/nntplib.py @@ -1056,6 +1056,8 @@ class NNTP(_NNTPBase): raise def _create_socket(self, timeout): + if timeout is not None and not timeout: + raise ValueError('Non-blocking socket (timeout=0) is not supported') sys.audit("nntplib.connect", self, self.host, self.port) return socket.create_connection((self.host, self.port), timeout) |