summaryrefslogtreecommitdiffstats
path: root/Lib/os.py
diff options
context:
space:
mode:
authorAntoine Pitrou <solipsis@pitrou.net>2011-03-19 16:00:37 (GMT)
committerAntoine Pitrou <solipsis@pitrou.net>2011-03-19 16:00:37 (GMT)
commit877766dee8e60c7971ed0cabba89fbe981c2ab1b (patch)
tree07c365e3a3389598a6df338d09be696836b7cf5f /Lib/os.py
parent5e98141f9f576934fe5635c66614f82be1ee0a9a (diff)
downloadcpython-877766dee8e60c7971ed0cabba89fbe981c2ab1b.zip
cpython-877766dee8e60c7971ed0cabba89fbe981c2ab1b.tar.gz
cpython-877766dee8e60c7971ed0cabba89fbe981c2ab1b.tar.bz2
Issue #11459: A `bufsize` value of 0 in subprocess.Popen() really creates
unbuffered pipes, such that select() works properly on them.
Diffstat (limited to 'Lib/os.py')
-rw-r--r--Lib/os.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/Lib/os.py b/Lib/os.py
index aa1a40f..b46c02f 100644
--- a/Lib/os.py
+++ b/Lib/os.py
@@ -629,11 +629,13 @@ if not _exists("urandom"):
return bs
# Supply os.popen()
-def popen(cmd, mode="r", buffering=None):
+def popen(cmd, mode="r", buffering=-1):
if not isinstance(cmd, str):
raise TypeError("invalid cmd type (%s, expected string)" % type(cmd))
if mode not in ("r", "w"):
raise ValueError("invalid mode %r" % mode)
+ if buffering == 0 or buffering == None:
+ raise ValueError("popen() does not support unbuffered streams")
import subprocess, io
if mode == "r":
proc = subprocess.Popen(cmd,