summaryrefslogtreecommitdiffstats
path: root/Lib/os.py
diff options
context:
space:
mode:
authorAntoine Pitrou <solipsis@pitrou.net>2011-03-19 16:04:13 (GMT)
committerAntoine Pitrou <solipsis@pitrou.net>2011-03-19 16:04:13 (GMT)
commit7b98d02302d7a43ee1d2fb1ac828b339ba9b424d (patch)
tree607d518818cc3643d1270dfa060ad9789206dc80 /Lib/os.py
parentd24c991f11541ccdb3cddade4a59ae0d2c0908bd (diff)
parent877766dee8e60c7971ed0cabba89fbe981c2ab1b (diff)
downloadcpython-7b98d02302d7a43ee1d2fb1ac828b339ba9b424d.zip
cpython-7b98d02302d7a43ee1d2fb1ac828b339ba9b424d.tar.gz
cpython-7b98d02302d7a43ee1d2fb1ac828b339ba9b424d.tar.bz2
Issue #11459: A `bufsize` value of 0 in subprocess.Popen() really creates
unbuffered pipes, such that select() works properly on them.
Diffstat (limited to 'Lib/os.py')
-rw-r--r--Lib/os.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/Lib/os.py b/Lib/os.py
index 3ef3db8..a894ee0 100644
--- a/Lib/os.py
+++ b/Lib/os.py
@@ -779,11 +779,13 @@ if not _exists("urandom"):
return bs
# Supply os.popen()
-def popen(cmd, mode="r", buffering=None):
+def popen(cmd, mode="r", buffering=-1):
if not isinstance(cmd, str):
raise TypeError("invalid cmd type (%s, expected string)" % type(cmd))
if mode not in ("r", "w"):
raise ValueError("invalid mode %r" % mode)
+ if buffering == 0 or buffering == None:
+ raise ValueError("popen() does not support unbuffered streams")
import subprocess, io
if mode == "r":
proc = subprocess.Popen(cmd,