#16112: platform.architecture does not correctly escape argument to /usr/bin/file. Use 'communicate()'

1 files changed, 3 insertions, 4 deletions

diff --git a/Lib/platform.py b/Lib/platform.py
index d177499..10b04bd 100755
--- a/Lib/platform.py
+++ b/Lib/platform.py
@@ -1045,13 +1045,12 @@ def _syscmd_file(target,default=''):
         return default
     target = _follow_symlinks(target)
     try:
-        with open(DEV_NULL) as dev_null:
-            proc = subprocess.Popen(['file', '-b', '--', target],
-                    stdout=subprocess.PIPE, stderr=dev_null)
+        proc = subprocess.Popen(['file', '-b', '--', target],
+                stdout=subprocess.PIPE, stderr=subprocess.DEVNULL)
 
     except (AttributeError,os.error):
         return default
-    output = proc.stdout.read()
+    output = proc.communicate()[0]
     rc = proc.wait()
     if not output or rc:
         return default