diff options
| author | Pablo Galindo <Pablogsal@gmail.com> | 2019-11-19 21:34:03 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-11-19 21:34:03 (GMT) |
| commit | 293dd23477eef6e7c1b1e26b5bb2c1e0d79ac3c2 (patch) | |
| tree | 295b4eee204f0d1e4723e62825a86310ddc27578 /Lib/poplib.py | |
| parent | c6b20be85c0de6f2355c67ae6e7e578941275cc0 (diff) | |
| download | cpython-293dd23477eef6e7c1b1e26b5bb2c1e0d79ac3c2.zip cpython-293dd23477eef6e7c1b1e26b5bb2c1e0d79ac3c2.tar.gz cpython-293dd23477eef6e7c1b1e26b5bb2c1e0d79ac3c2.tar.bz2 | |
Remove binding of captured exceptions when not used to reduce the chances of creating cycles (GH-17246)
Capturing exceptions into names can lead to reference cycles though the __traceback__ attribute of the exceptions in some obscure cases that have been reported previously and fixed individually. As these variables are not used anyway, we can remove the binding to reduce the chances of creating reference cycles.
See for example GH-13135
Diffstat (limited to 'Lib/poplib.py')
| -rw-r--r-- | Lib/poplib.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Lib/poplib.py b/Lib/poplib.py index e3bd2ab..0b6750d 100644 --- a/Lib/poplib.py +++ b/Lib/poplib.py @@ -385,7 +385,7 @@ class POP3: for capline in rawcaps: capnm, capargs = _parsecap(capline) caps[capnm] = capargs - except error_proto as _err: + except error_proto: raise error_proto('-ERR CAPA not supported by server') return caps |