diff options
author | Hynek Schlawack <hs@ox.cx> | 2012-07-17 11:05:43 (GMT) |
---|---|---|
committer | Hynek Schlawack <hs@ox.cx> | 2012-07-17 11:05:43 (GMT) |
commit | c5a45669229906a2ff8ea87bd69d1df2feac8ffc (patch) | |
tree | fcdd2ca889494179489a81336322daddd16c4c66 /Lib/posixpath.py | |
parent | eb3e62f1c88e4a94be95e38e01541ebb52079d3a (diff) | |
download | cpython-c5a45669229906a2ff8ea87bd69d1df2feac8ffc.zip cpython-c5a45669229906a2ff8ea87bd69d1df2feac8ffc.tar.gz cpython-c5a45669229906a2ff8ea87bd69d1df2feac8ffc.tar.bz2 |
#15377: Make posixpath.join() more strict when checking for str/bytes mix
Based on a patch by Nick Coghlan.
Diffstat (limited to 'Lib/posixpath.py')
-rw-r--r-- | Lib/posixpath.py | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/Lib/posixpath.py b/Lib/posixpath.py index 84bcc13..7a4daa8b 100644 --- a/Lib/posixpath.py +++ b/Lib/posixpath.py @@ -83,11 +83,12 @@ def join(a, *p): else: path += sep + b except TypeError: - strs = [isinstance(s, str) for s in (a, ) + p] - if any(strs) and not all(strs): + valid_types = all(isinstance(s, (str, bytes, bytearray)) + for s in (a, ) + p) + if valid_types: + # Must have a mixture of text and binary data raise TypeError("Can't mix strings and bytes in path components.") - else: - raise + raise return path |