summaryrefslogtreecommitdiffstats
path: root/Lib/random.py
diff options
context:
space:
mode:
authorRam Rachum <ram@rachum.com>2020-09-29 01:32:10 (GMT)
committerGitHub <noreply@github.com>2020-09-29 01:32:10 (GMT)
commitb0dfc7581697f20385813582de7e92ba6ba0105f (patch)
tree56cb713f1bf2d302363b133682e5ad4afa1e739e /Lib/random.py
parente8acc355d430b45f1c3ff83312e72272262a854f (diff)
downloadcpython-b0dfc7581697f20385813582de7e92ba6ba0105f.zip
cpython-b0dfc7581697f20385813582de7e92ba6ba0105f.tar.gz
cpython-b0dfc7581697f20385813582de7e92ba6ba0105f.tar.bz2
bpo-41773: Raise exception for non-finite weights in random.choices(). (GH-22441)
Diffstat (limited to 'Lib/random.py')
-rw-r--r--Lib/random.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/Lib/random.py b/Lib/random.py
index 3ea369b..139e8a4 100644
--- a/Lib/random.py
+++ b/Lib/random.py
@@ -48,7 +48,7 @@ General notes on the underlying Mersenne Twister core generator:
from warnings import warn as _warn
from math import log as _log, exp as _exp, pi as _pi, e as _e, ceil as _ceil
from math import sqrt as _sqrt, acos as _acos, cos as _cos, sin as _sin
-from math import tau as TWOPI, floor as _floor
+from math import tau as TWOPI, floor as _floor, isfinite as _isfinite
from os import urandom as _urandom
from _collections_abc import Set as _Set, Sequence as _Sequence
from itertools import accumulate as _accumulate, repeat as _repeat
@@ -492,6 +492,8 @@ class Random(_random.Random):
total = cum_weights[-1] + 0.0 # convert to float
if total <= 0.0:
raise ValueError('Total of weights must be greater than zero')
+ if not _isfinite(total):
+ raise ValueError('Total of weights must be finite')
bisect = _bisect
hi = n - 1
return [population[bisect(cum_weights, random() * total, 0, hi)]