diff options
author | R David Murray <rdmurray@bitdance.com> | 2013-03-21 01:12:17 (GMT) |
---|---|---|
committer | R David Murray <rdmurray@bitdance.com> | 2013-03-21 01:12:17 (GMT) |
commit | f1a40b4ec5bd25411189e33de1cdabdc6780cd8c (patch) | |
tree | 154a2305376a4138927c8d31c810e8c7dd2bbd85 /Lib/smtplib.py | |
parent | f219c8da490cdffcacdc419414871fae761d499d (diff) | |
parent | d312c740f15b2ee8ba242fb779884f7e19b28a7e (diff) | |
download | cpython-f1a40b4ec5bd25411189e33de1cdabdc6780cd8c.zip cpython-f1a40b4ec5bd25411189e33de1cdabdc6780cd8c.tar.gz cpython-f1a40b4ec5bd25411189e33de1cdabdc6780cd8c.tar.bz2 |
Merge: #5713: Handle 421 error codes during sendmail by closing the socket.
This is a partial fix to the issue of servers disconnecting unexpectedly; in
this case the 421 says they are disconnecting, so we close the socket and
return the 421 in the appropriate error context.
Original patch by Mark Sapiro, updated by Kushal Das, with additional
tests by me.
Diffstat (limited to 'Lib/smtplib.py')
-rw-r--r-- | Lib/smtplib.py | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/Lib/smtplib.py b/Lib/smtplib.py index c949d77..562a182 100644 --- a/Lib/smtplib.py +++ b/Lib/smtplib.py @@ -751,7 +751,10 @@ class SMTP: esmtp_opts.append(option) (code, resp) = self.mail(from_addr, esmtp_opts) if code != 250: - self.rset() + if code == 421: + self.close() + else: + self.rset() raise SMTPSenderRefused(code, resp, from_addr) senderrs = {} if isinstance(to_addrs, str): @@ -760,13 +763,19 @@ class SMTP: (code, resp) = self.rcpt(each, rcpt_options) if (code != 250) and (code != 251): senderrs[each] = (code, resp) + if code == 421: + self.close() + raise SMTPRecipientsRefused(senderrs) if len(senderrs) == len(to_addrs): # the server refused all our recipients self.rset() raise SMTPRecipientsRefused(senderrs) (code, resp) = self.data(msg) if code != 250: - self.rset() + if code == 421: + self.close() + else: + self.rset() raise SMTPDataError(code, resp) #if we got here then somebody got our mail return senderrs |