diff options
author | Berker Peksag <berker.peksag@gmail.com> | 2016-06-12 19:34:49 (GMT) |
---|---|---|
committer | Berker Peksag <berker.peksag@gmail.com> | 2016-06-12 19:34:49 (GMT) |
commit | 1003b34c71d53ccb88ae2768aaba503ae6b5bc16 (patch) | |
tree | 31cf203e12c8091b1b5fa0040dd143ff76aa647f /Lib/sqlite3/test/transactions.py | |
parent | 0e1d6802ff03666bced6548e75b8459c88c2b720 (diff) | |
download | cpython-1003b34c71d53ccb88ae2768aaba503ae6b5bc16.zip cpython-1003b34c71d53ccb88ae2768aaba503ae6b5bc16.tar.gz cpython-1003b34c71d53ccb88ae2768aaba503ae6b5bc16.tar.bz2 |
Modernize sqlite3 tests
Update current tests that use old pattern with assertRaises
to make them more maintainable.
Diffstat (limited to 'Lib/sqlite3/test/transactions.py')
-rw-r--r-- | Lib/sqlite3/test/transactions.py | 21 |
1 files changed, 3 insertions, 18 deletions
diff --git a/Lib/sqlite3/test/transactions.py b/Lib/sqlite3/test/transactions.py index feb4fa1..eae26c4 100644 --- a/Lib/sqlite3/test/transactions.py +++ b/Lib/sqlite3/test/transactions.py @@ -118,13 +118,8 @@ class TransactionTests(unittest.TestCase): return self.cur1.execute("create table test(i)") self.cur1.execute("insert into test(i) values (5)") - try: + with self.assertRaises(sqlite.OperationalError): self.cur2.execute("insert into test(i) values (5)") - self.fail("should have raised an OperationalError") - except sqlite.OperationalError: - pass - except: - self.fail("should have raised an OperationalError") def CheckLocking(self): """ @@ -137,13 +132,8 @@ class TransactionTests(unittest.TestCase): return self.cur1.execute("create table test(i)") self.cur1.execute("insert into test(i) values (5)") - try: + with self.assertRaises(sqlite.OperationalError): self.cur2.execute("insert into test(i) values (5)") - self.fail("should have raised an OperationalError") - except sqlite.OperationalError: - pass - except: - self.fail("should have raised an OperationalError") # NO self.con2.rollback() HERE!!! self.con1.commit() @@ -159,13 +149,8 @@ class TransactionTests(unittest.TestCase): cur.execute("select 1 union select 2 union select 3") con.rollback() - try: + with self.assertRaises(sqlite.InterfaceError): cur.fetchall() - self.fail("InterfaceError should have been raised") - except sqlite.InterfaceError as e: - pass - except: - self.fail("InterfaceError should have been raised") class SpecialCommandTests(unittest.TestCase): def setUp(self): |