summaryrefslogtreecommitdiffstats
path: root/Lib/ssl.py
diff options
context:
space:
mode:
authorjuhovh <juhovh@iki.fi>2021-04-18 11:11:48 (GMT)
committerGitHub <noreply@github.com>2021-04-18 11:11:48 (GMT)
commit49fdf118aeda891401d638ac32296c7d55d54678 (patch)
tree28b2e0df7618d9934e70d4a72019bcfbff08d18b /Lib/ssl.py
parent2798f247c0747d28cb857fa80803797b24696cb6 (diff)
downloadcpython-49fdf118aeda891401d638ac32296c7d55d54678.zip
cpython-49fdf118aeda891401d638ac32296c7d55d54678.tar.gz
cpython-49fdf118aeda891401d638ac32296c7d55d54678.tar.bz2
bpo-36076: Add SNI support to ssl.get_server_certificate. (GH-16820)
Many servers in the cloud environment require SNI to be used during the SSL/TLS handshake, therefore it is not possible to fetch their certificates using the ssl.get_server_certificate interface. This change adds an additional optional hostname argument that can be used to set the SNI. Note that it is intentionally a separate argument instead of using the host part of the addr tuple, because one might want to explicitly fetch the default certificate or fetch a certificate from a specific IP address with the specified SNI hostname. A separate argument also works better for backwards compatibility. Automerge-Triggered-By: GH:tiran
Diffstat (limited to 'Lib/ssl.py')
-rw-r--r--Lib/ssl.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/Lib/ssl.py b/Lib/ssl.py
index 9c1ba58..99d0852 100644
--- a/Lib/ssl.py
+++ b/Lib/ssl.py
@@ -1475,7 +1475,7 @@ def get_server_certificate(addr, ssl_version=PROTOCOL_TLS, ca_certs=None):
cert_reqs=cert_reqs,
cafile=ca_certs)
with create_connection(addr) as sock:
- with context.wrap_socket(sock) as sslsock:
+ with context.wrap_socket(sock, server_hostname=host) as sslsock:
dercert = sslsock.getpeercert(True)
return DER_cert_to_PEM_cert(dercert)