diff options
| author | Gustavo Niemeyer <gustavo@niemeyer.net> | 2006-09-06 01:58:52 (GMT) |
|---|---|---|
| committer | Gustavo Niemeyer <gustavo@niemeyer.net> | 2006-09-06 01:58:52 (GMT) |
| commit | 8cb64eaaf38aecea67901dc4ecb2149805356a99 (patch) | |
| tree | 3134c58af3ab72eae1545bb260a4b13766812c6e /Lib/subprocess.py | |
| parent | b15a0ccf6d5176a5064f63ddab7464c350611a2a (diff) | |
| download | cpython-8cb64eaaf38aecea67901dc4ecb2149805356a99.zip cpython-8cb64eaaf38aecea67901dc4ecb2149805356a99.tar.gz cpython-8cb64eaaf38aecea67901dc4ecb2149805356a99.tar.bz2 | |
Fixing #1531862: Do not close standard file descriptors in the
subprocess module.
Diffstat (limited to 'Lib/subprocess.py')
| -rw-r--r-- | Lib/subprocess.py | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/Lib/subprocess.py b/Lib/subprocess.py index 5438f15..7c229dc 100644 --- a/Lib/subprocess.py +++ b/Lib/subprocess.py @@ -1000,14 +1000,10 @@ class Popen(object): if errwrite: os.dup2(errwrite, 2) - # Close pipe fds. Make sure we doesn't close the same - # fd more than once. - if p2cread: - os.close(p2cread) - if c2pwrite and c2pwrite not in (p2cread,): - os.close(c2pwrite) - if errwrite and errwrite not in (p2cread, c2pwrite): - os.close(errwrite) + # Close pipe fds. Make sure we don't close the same + # fd more than once, or standard fds. + for fd in set((p2cread, c2pwrite, errwrite))-set((0,1,2)): + if fd: os.close(fd) # Close all other fds, if asked for if close_fds: |