diff options
| author | Gregory P. Smith <greg@krypto.org> | 2013-12-01 03:04:00 (GMT) |
|---|---|---|
| committer | Gregory P. Smith <greg@krypto.org> | 2013-12-01 03:04:00 (GMT) |
| commit | 1c27e3c7fbf8ee33e20677558e7e394a1bdb70d0 (patch) | |
| tree | 343d58bb4fdf0404e2aea3db12a4280d0188fbed /Lib/subprocess.py | |
| parent | 2ccf8e969c5e870a6c416ac7970c9f94c0da86fd (diff) | |
| parent | 1eda9e7c3074bfe37674c8140b3d02bf94caf4f3 (diff) | |
| download | cpython-1c27e3c7fbf8ee33e20677558e7e394a1bdb70d0.zip cpython-1c27e3c7fbf8ee33e20677558e7e394a1bdb70d0.tar.gz cpython-1c27e3c7fbf8ee33e20677558e7e394a1bdb70d0.tar.bz2 | |
Fixes Issue #15798 - subprocess.Popen() no longer fails if file
descriptor 0, 1 or 2 is closed.
Diffstat (limited to 'Lib/subprocess.py')
| -rw-r--r-- | Lib/subprocess.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/Lib/subprocess.py b/Lib/subprocess.py index 88355ad..f717c82 100644 --- a/Lib/subprocess.py +++ b/Lib/subprocess.py @@ -1361,7 +1361,10 @@ class Popen(object): executable_list = tuple( os.path.join(os.fsencode(dir), executable) for dir in os.get_exec_path(env)) - fds_to_keep = set(pass_fds) + # Never close stdin, stdout and stderr for the child. + fds_to_keep = {0,1,2} + fds_to_keep.update(pass_fds) + # Our child uses this one to signal error before exec(). fds_to_keep.add(errpipe_write) self.pid = _posixsubprocess.fork_exec( args, executable_list, |