summaryrefslogtreecommitdiffstats
path: root/Lib/test/test_asyncio/test_events.py
diff options
context:
space:
mode:
authorVictor Stinner <vstinner@python.org>2019-12-11 10:30:03 (GMT)
committerGitHub <noreply@github.com>2019-12-11 10:30:03 (GMT)
commit0d63bacefd2e5b937ec6b0ec3053777c09941b4a (patch)
tree638bde819a554379c8c5aff31ba8d6a1feeb1db1 /Lib/test/test_asyncio/test_events.py
parentb7a0109cd2bafaa21a4d50aad307e901c68f9156 (diff)
downloadcpython-0d63bacefd2e5b937ec6b0ec3053777c09941b4a.zip
cpython-0d63bacefd2e5b937ec6b0ec3053777c09941b4a.tar.gz
cpython-0d63bacefd2e5b937ec6b0ec3053777c09941b4a.tar.bz2
bpo-38614: Use test.support.SHORT_TIMEOUT constant (GH-17566)
Replace hardcoded timeout constants in tests with SHORT_TIMEOUT of test.support, so it's easier to ajdust this timeout for all tests at once. SHORT_TIMEOUT is 30 seconds by default, but it can be longer depending on --timeout command line option. The change makes almost all timeouts longer, except test_reap_children() of test_support which is made 2x shorter: SHORT_TIMEOUT should be enough. If this test starts to fail, LONG_TIMEOUT should be used instead. Uniformize also "from test import support" import in some test files.
Diffstat (limited to 'Lib/test/test_asyncio/test_events.py')
-rw-r--r--Lib/test/test_asyncio/test_events.py14
1 files changed, 8 insertions, 6 deletions
diff --git a/Lib/test/test_asyncio/test_events.py b/Lib/test/test_asyncio/test_events.py
index 52467d8..4cbd1ed 100644
--- a/Lib/test/test_asyncio/test_events.py
+++ b/Lib/test/test_asyncio/test_events.py
@@ -1475,12 +1475,12 @@ class EventLoopTestsMixin:
return len(data)
test_utils.run_until(self.loop, lambda: reader(data) >= 1,
- timeout=10)
+ timeout=support.SHORT_TIMEOUT)
self.assertEqual(b'1', data)
transport.write(b'2345')
test_utils.run_until(self.loop, lambda: reader(data) >= 5,
- timeout=10)
+ timeout=support.SHORT_TIMEOUT)
self.assertEqual(b'12345', data)
self.assertEqual('CONNECTED', proto.state)
@@ -1531,27 +1531,29 @@ class EventLoopTestsMixin:
return len(data)
write_transport.write(b'1')
- test_utils.run_until(self.loop, lambda: reader(data) >= 1, timeout=10)
+ test_utils.run_until(self.loop, lambda: reader(data) >= 1,
+ timeout=support.SHORT_TIMEOUT)
self.assertEqual(b'1', data)
self.assertEqual(['INITIAL', 'CONNECTED'], read_proto.state)
self.assertEqual('CONNECTED', write_proto.state)
os.write(master, b'a')
test_utils.run_until(self.loop, lambda: read_proto.nbytes >= 1,
- timeout=10)
+ timeout=support.SHORT_TIMEOUT)
self.assertEqual(['INITIAL', 'CONNECTED'], read_proto.state)
self.assertEqual(1, read_proto.nbytes)
self.assertEqual('CONNECTED', write_proto.state)
write_transport.write(b'2345')
- test_utils.run_until(self.loop, lambda: reader(data) >= 5, timeout=10)
+ test_utils.run_until(self.loop, lambda: reader(data) >= 5,
+ timeout=support.SHORT_TIMEOUT)
self.assertEqual(b'12345', data)
self.assertEqual(['INITIAL', 'CONNECTED'], read_proto.state)
self.assertEqual('CONNECTED', write_proto.state)
os.write(master, b'bcde')
test_utils.run_until(self.loop, lambda: read_proto.nbytes >= 5,
- timeout=10)
+ timeout=support.SHORT_TIMEOUT)
self.assertEqual(['INITIAL', 'CONNECTED'], read_proto.state)
self.assertEqual(5, read_proto.nbytes)
self.assertEqual('CONNECTED', write_proto.state)