summaryrefslogtreecommitdiffstats
path: root/Lib/test/test_asyncio/test_taskgroups.py
diff options
context:
space:
mode:
authorGuido van Rossum <guido@python.org>2022-06-30 17:10:46 (GMT)
committerGitHub <noreply@github.com>2022-06-30 17:10:46 (GMT)
commit594c3699492bfb007650538726d953cbed55de04 (patch)
tree0c08bef359427752e98c566d436e5d3208b1b490 /Lib/test/test_asyncio/test_taskgroups.py
parent4261b6bffc0b8bb5c6d4d80578a81b7520f4aefc (diff)
downloadcpython-594c3699492bfb007650538726d953cbed55de04.zip
cpython-594c3699492bfb007650538726d953cbed55de04.tar.gz
cpython-594c3699492bfb007650538726d953cbed55de04.tar.bz2
GH-94398: TaskGroup: Fail create_task() during shutdown (GH-94400)
Once the task group is shutting down, it should not be possible to create a new task. Here "shutting down" means `self._aborting` is set, indicating that at least one task has failed and we have cancelled all others. Co-authored-by: Ɓukasz Langa <lukasz@langa.pl>
Diffstat (limited to 'Lib/test/test_asyncio/test_taskgroups.py')
-rw-r--r--Lib/test/test_asyncio/test_taskgroups.py27
1 files changed, 23 insertions, 4 deletions
diff --git a/Lib/test/test_asyncio/test_taskgroups.py b/Lib/test/test_asyncio/test_taskgroups.py
index 69369a6..26fb5e4 100644
--- a/Lib/test/test_asyncio/test_taskgroups.py
+++ b/Lib/test/test_asyncio/test_taskgroups.py
@@ -122,10 +122,8 @@ class TestTaskGroup(unittest.IsolatedAsyncioTestCase):
self.assertTrue(t2.cancelled())
async def test_cancel_children_on_child_error(self):
- """
- When a child task raises an error, the rest of the children
- are cancelled and the errors are gathered into an EG.
- """
+ # When a child task raises an error, the rest of the children
+ # are cancelled and the errors are gathered into an EG.
NUM = 0
t2_cancel = False
@@ -722,6 +720,27 @@ class TestTaskGroup(unittest.IsolatedAsyncioTestCase):
await t2
self.assertEqual(2, ctx.get(cvar))
+ async def test_taskgroup_no_create_task_after_failure(self):
+ async def coro1():
+ await asyncio.sleep(0.001)
+ 1 / 0
+ async def coro2(g):
+ try:
+ await asyncio.sleep(1)
+ except asyncio.CancelledError:
+ with self.assertRaises(RuntimeError):
+ g.create_task(c1 := coro1())
+ # We still have to await c1 to avoid a warning
+ with self.assertRaises(ZeroDivisionError):
+ await c1
+
+ with self.assertRaises(ExceptionGroup) as cm:
+ async with taskgroups.TaskGroup() as g:
+ g.create_task(coro1())
+ g.create_task(coro2(g))
+
+ self.assertEqual(get_error_types(cm.exception), {ZeroDivisionError})
+
if __name__ == "__main__":
unittest.main()