diff options
| author | Victor Stinner <victor.stinner@gmail.com> | 2015-02-04 13:51:23 (GMT) |
|---|---|---|
| committer | Victor Stinner <victor.stinner@gmail.com> | 2015-02-04 13:51:23 (GMT) |
| commit | 2fc2313038cb2ef0f375808244783235b8ad6455 (patch) | |
| tree | 1b1e1b25ac82f667d97b7b5172d9d5c2e53e019a /Lib/test/test_asyncio | |
| parent | aa41b9b22b139d241dd97f8baf0fda56fe719c36 (diff) | |
| download | cpython-2fc2313038cb2ef0f375808244783235b8ad6455.zip cpython-2fc2313038cb2ef0f375808244783235b8ad6455.tar.gz cpython-2fc2313038cb2ef0f375808244783235b8ad6455.tar.bz2 | |
asyncio: Only call _check_resolved_address() in debug mode
* _check_resolved_address() is implemented with getaddrinfo() which is slow
* If available, use socket.inet_pton() instead of socket.getaddrinfo(), because
it is much faster
Microbenchmark (timeit) on Fedora 21 (Python 3.4, Linux 3.17, glibc 2.20) to
validate the IPV4 address "127.0.0.1" or the IPv6 address "::1":
* getaddrinfo() 10.4 usec per loop
* inet_pton(): 0.285 usec per loop
On glibc older than 2.14, getaddrinfo() always requests the list of all local
IP addresses to the kernel (using a NETLINK socket). getaddrinfo() has other
known issues, it's better to avoid it when it is possible.
Diffstat (limited to 'Lib/test/test_asyncio')
| -rw-r--r-- | Lib/test/test_asyncio/test_events.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Lib/test/test_asyncio/test_events.py b/Lib/test/test_asyncio/test_events.py index 4b957d8..8fbba8f 100644 --- a/Lib/test/test_asyncio/test_events.py +++ b/Lib/test/test_asyncio/test_events.py @@ -1437,6 +1437,10 @@ class EventLoopTestsMixin: 'selector': self.loop._selector.__class__.__name__}) def test_sock_connect_address(self): + # In debug mode, sock_connect() must ensure that the address is already + # resolved (call _check_resolved_address()) + self.loop.set_debug(True) + addresses = [(socket.AF_INET, ('www.python.org', 80))] if support.IPV6_ENABLED: addresses.extend(( |