summaryrefslogtreecommitdiffstats
path: root/Lib/test/test_builtin.py
diff options
context:
space:
mode:
authorINADA Naoki <methane@users.noreply.github.com>2018-09-26 03:59:00 (GMT)
committerMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2018-09-26 03:59:00 (GMT)
commit2aaf98c16ae3070378de523a173e29644037d8bd (patch)
tree78b0a34f1d41d23a8b66e607a30fedfd2eb2a352 /Lib/test/test_builtin.py
parentd345bb4d9b6e16c681cd8a4e1fff94ecd6b0bb09 (diff)
downloadcpython-2aaf98c16ae3070378de523a173e29644037d8bd.zip
cpython-2aaf98c16ae3070378de523a173e29644037d8bd.tar.gz
cpython-2aaf98c16ae3070378de523a173e29644037d8bd.tar.bz2
bpo-34320: Fix dict(o) didn't copy order of dict subclass (GH-8624)
When dict subclass overrides order (`__iter__()`, `keys()`, and `items()`), `dict(o)` should use it instead of dict ordering. https://bugs.python.org/issue34320
Diffstat (limited to 'Lib/test/test_builtin.py')
-rw-r--r--Lib/test/test_builtin.py9
1 files changed, 9 insertions, 0 deletions
diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py
index 46cf2d3..dafcf00 100644
--- a/Lib/test/test_builtin.py
+++ b/Lib/test/test_builtin.py
@@ -1968,6 +1968,15 @@ class TestType(unittest.TestCase):
with self.assertRaises(TypeError):
type('A', (B,), {'__slots__': '__weakref__'})
+ def test_namespace_order(self):
+ # bpo-34320: namespace should preserve order
+ od = collections.OrderedDict([('a', 1), ('b', 2)])
+ od.move_to_end('a')
+ expected = list(od.items())
+
+ C = type('C', (), od)
+ self.assertEqual(list(C.__dict__.items())[:2], [('b', 2), ('a', 1)])
+
def load_tests(loader, tests, pattern):
from doctest import DocTestSuite