summaryrefslogtreecommitdiffstats
path: root/Lib/test/test_contextlib.py
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2023-01-03 16:18:45 (GMT)
committerGitHub <noreply@github.com>2023-01-03 16:18:45 (GMT)
commit861cdefc1bccd419bd268a9f60b34bffbaff9ea2 (patch)
tree3449e145139fb7ba6f2a78806097919a42cbb542 /Lib/test/test_contextlib.py
parentb99ac1dbc081e4f2d2e68906e9c7c535e628611a (diff)
downloadcpython-861cdefc1bccd419bd268a9f60b34bffbaff9ea2.zip
cpython-861cdefc1bccd419bd268a9f60b34bffbaff9ea2.tar.gz
cpython-861cdefc1bccd419bd268a9f60b34bffbaff9ea2.tar.bz2
gh-95882: fix regression in the traceback of exceptions propagated from inside a contextlib context manager (GH-95883)
(cherry picked from commit b3722ca058f6a6d6505cf2ea9ffabaf7fb6b6e19) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Diffstat (limited to 'Lib/test/test_contextlib.py')
-rw-r--r--Lib/test/test_contextlib.py30
1 files changed, 27 insertions, 3 deletions
diff --git a/Lib/test/test_contextlib.py b/Lib/test/test_contextlib.py
index 31f5c74..ec06785 100644
--- a/Lib/test/test_contextlib.py
+++ b/Lib/test/test_contextlib.py
@@ -104,15 +104,39 @@ class ContextManagerTestCase(unittest.TestCase):
self.assertEqual(frames[0].line, '1/0')
# Repeat with RuntimeError (which goes through a different code path)
+ class RuntimeErrorSubclass(RuntimeError):
+ pass
+
try:
with f():
- raise NotImplementedError(42)
- except NotImplementedError as e:
+ raise RuntimeErrorSubclass(42)
+ except RuntimeErrorSubclass as e:
frames = traceback.extract_tb(e.__traceback__)
self.assertEqual(len(frames), 1)
self.assertEqual(frames[0].name, 'test_contextmanager_traceback')
- self.assertEqual(frames[0].line, 'raise NotImplementedError(42)')
+ self.assertEqual(frames[0].line, 'raise RuntimeErrorSubclass(42)')
+
+ class StopIterationSubclass(StopIteration):
+ pass
+
+ for stop_exc in (
+ StopIteration('spam'),
+ StopIterationSubclass('spam'),
+ ):
+ with self.subTest(type=type(stop_exc)):
+ try:
+ with f():
+ raise stop_exc
+ except type(stop_exc) as e:
+ self.assertIs(e, stop_exc)
+ frames = traceback.extract_tb(e.__traceback__)
+ else:
+ self.fail(f'{stop_exc} was suppressed')
+
+ self.assertEqual(len(frames), 1)
+ self.assertEqual(frames[0].name, 'test_contextmanager_traceback')
+ self.assertEqual(frames[0].line, 'raise stop_exc')
def test_contextmanager_no_reraise(self):
@contextmanager