diff options
author | Victor Stinner <vstinner@redhat.com> | 2018-06-19 15:37:07 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-06-19 15:37:07 (GMT) |
commit | c44d8e5db6fb9d3847c49e9c9718f2b4cf71f506 (patch) | |
tree | e628b36830f1d00616e5b8a7ca7a83880f05f00f /Lib/test/test_dbm_gnu.py | |
parent | c7f02a965936f197354d7f4e6360f4cfc86817ed (diff) | |
download | cpython-c44d8e5db6fb9d3847c49e9c9718f2b4cf71f506.zip cpython-c44d8e5db6fb9d3847c49e9c9718f2b4cf71f506.tar.gz cpython-c44d8e5db6fb9d3847c49e9c9718f2b4cf71f506.tar.bz2 |
bpo-33901: Better test_dbm_gnu.test_reorganize() fix (GH-7795)
Fix test_dbm_gnu.test_reorganize() on macOS with gdbm 1.15: add a
larger value to make sure that the file size changes.
Diffstat (limited to 'Lib/test/test_dbm_gnu.py')
-rw-r--r-- | Lib/test/test_dbm_gnu.py | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/Lib/test/test_dbm_gnu.py b/Lib/test/test_dbm_gnu.py index 8d76fc7..379601a 100644 --- a/Lib/test/test_dbm_gnu.py +++ b/Lib/test/test_dbm_gnu.py @@ -72,9 +72,13 @@ class TestGdbm(unittest.TestCase): self.g = gdbm.open(filename, 'c') size0 = os.path.getsize(filename) - self.g['x'] = 'x' * 10000 + # bpo-33901: on macOS with gdbm 1.15, an empty database uses 16 MiB + # and adding an entry of 10,000 B has no effect on the file size. + # Add size0 bytes to make sure that the file size changes. + value_size = max(size0, 10000) + self.g['x'] = 'x' * value_size size1 = os.path.getsize(filename) - self.assertGreaterEqual(size1, size0) + self.assertGreater(size1, size0) del self.g['x'] # 'size' is supposed to be the same even after deleting an entry. @@ -82,7 +86,7 @@ class TestGdbm(unittest.TestCase): self.g.reorganize() size2 = os.path.getsize(filename) - self.assertLessEqual(size2, size1) + self.assertLess(size2, size1) self.assertGreaterEqual(size2, size0) def test_context_manager(self): |