diff options
author | Ben Kallus <49924171+kenballus@users.noreply.github.com> | 2023-05-12 20:25:58 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-05-12 20:25:58 (GMT) |
commit | cf720acfcbd8c9c25a706a4b6df136465a803992 (patch) | |
tree | 5907abcc053c6355e63190ff0c2bc7124ca39225 /Lib/test/test_httpservers.py | |
parent | 25db95d224d18fb7b7f53165aeaa87632b0230f2 (diff) | |
download | cpython-cf720acfcbd8c9c25a706a4b6df136465a803992.zip cpython-cf720acfcbd8c9c25a706a4b6df136465a803992.tar.gz cpython-cf720acfcbd8c9c25a706a4b6df136465a803992.tar.bz2 |
gh-103204: `http.server` - Enforce that HTTP version numbers must consist only of digits (#103205)
Reject HTTP requests with invalid http/x.y version numbers: x or y being non-digits or too-long.
---------
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Diffstat (limited to 'Lib/test/test_httpservers.py')
-rw-r--r-- | Lib/test/test_httpservers.py | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/Lib/test/test_httpservers.py b/Lib/test/test_httpservers.py index 0382b5e..cdd1bea 100644 --- a/Lib/test/test_httpservers.py +++ b/Lib/test/test_httpservers.py @@ -164,6 +164,27 @@ class BaseHTTPServerTestCase(BaseTestCase): res = self.con.getresponse() self.assertEqual(res.status, HTTPStatus.BAD_REQUEST) + def test_version_signs_and_underscores(self): + self.con._http_vsn_str = 'HTTP/-9_9_9.+9_9_9' + self.con.putrequest('GET', '/') + self.con.endheaders() + res = self.con.getresponse() + self.assertEqual(res.status, HTTPStatus.BAD_REQUEST) + + def test_major_version_number_too_long(self): + self.con._http_vsn_str = 'HTTP/909876543210.0' + self.con.putrequest('GET', '/') + self.con.endheaders() + res = self.con.getresponse() + self.assertEqual(res.status, HTTPStatus.BAD_REQUEST) + + def test_minor_version_number_too_long(self): + self.con._http_vsn_str = 'HTTP/1.909876543210' + self.con.putrequest('GET', '/') + self.con.endheaders() + res = self.con.getresponse() + self.assertEqual(res.status, HTTPStatus.BAD_REQUEST) + def test_version_none_get(self): self.con._http_vsn_str = '' self.con.putrequest('GET', '/') |