diff options
author | Gregory P. Smith <greg@krypto.org> | 2019-09-13 16:13:51 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-09-13 16:13:51 (GMT) |
commit | 5b9ff7a0dcb16d6f5c3cd4f1f52e0ca6a4bde586 (patch) | |
tree | 617e86d74e51ffe2b915e2c89279c04793a838e4 /Lib/test/test_inspect.py | |
parent | 2ccb50cf773881255c5669942a093eb68ad042f6 (diff) | |
download | cpython-5b9ff7a0dcb16d6f5c3cd4f1f52e0ca6a4bde586.zip cpython-5b9ff7a0dcb16d6f5c3cd4f1f52e0ca6a4bde586.tar.gz cpython-5b9ff7a0dcb16d6f5c3cd4f1f52e0ca6a4bde586.tar.bz2 |
bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108)
https://bugs.python.org/issue34706
Specifically in the case of a class that does not override its
constructor signature inherited from object.
These are Buck Evan @bukzor's changes cherrypicked from GH-9344.
Diffstat (limited to 'Lib/test/test_inspect.py')
-rw-r--r-- | Lib/test/test_inspect.py | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/Lib/test/test_inspect.py b/Lib/test/test_inspect.py index 6c9f529..7148dfa 100644 --- a/Lib/test/test_inspect.py +++ b/Lib/test/test_inspect.py @@ -3153,14 +3153,21 @@ class TestSignatureObject(unittest.TestCase): class MySignature(inspect.Signature): pass def foo(a, *, b:1): pass foo_sig = MySignature.from_callable(foo) - self.assertTrue(isinstance(foo_sig, MySignature)) + self.assertIsInstance(foo_sig, MySignature) + + def test_signature_from_callable_class(self): + # A regression test for a class inheriting its signature from `object`. + class MySignature(inspect.Signature): pass + class foo: pass + foo_sig = MySignature.from_callable(foo) + self.assertIsInstance(foo_sig, MySignature) @unittest.skipIf(MISSING_C_DOCSTRINGS, "Signature information for builtins requires docstrings") def test_signature_from_callable_builtin_obj(self): class MySignature(inspect.Signature): pass sig = MySignature.from_callable(_pickle.Pickler) - self.assertTrue(isinstance(sig, MySignature)) + self.assertIsInstance(sig, MySignature) def test_signature_definition_order_preserved_on_kwonly(self): for fn in signatures_with_lexicographic_keyword_only_parameters(): |