diff options
author | Victor Stinner <victor.stinner@gmail.com> | 2017-09-19 16:36:54 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-09-19 16:36:54 (GMT) |
commit | 9abee722d448c1c00c7d4e11ce242ec7b13e5c49 (patch) | |
tree | 52af3dbb3ff6a4a8e28be76f43ef7d4df31deec6 /Lib/test/test_io.py | |
parent | a92941ff12c1d554f42c05ed24621894a758b40f (diff) | |
download | cpython-9abee722d448c1c00c7d4e11ce242ec7b13e5c49.zip cpython-9abee722d448c1c00c7d4e11ce242ec7b13e5c49.tar.gz cpython-9abee722d448c1c00c7d4e11ce242ec7b13e5c49.tar.bz2 |
bpo-31479: Always reset the signal alarm in tests (#3588)
* bpo-31479: Always reset the signal alarm in tests
Use "try: ... finally: signal.signal(0)" pattern to make sure that
tests don't "leak" a pending fatal signal alarm.
* Move two more alarm() calls into the try block
Fix also typo: replace signal.signal(0) with signal.alarm(0)
* Move another signal.alarm() into the try block
Diffstat (limited to 'Lib/test/test_io.py')
-rw-r--r-- | Lib/test/test_io.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py index d4685dd..ce4ed1b8 100644 --- a/Lib/test/test_io.py +++ b/Lib/test/test_io.py @@ -3940,6 +3940,7 @@ class SignalsTest(unittest.TestCase): if isinstance(exc, RuntimeError): self.assertTrue(str(exc).startswith("reentrant call"), str(exc)) finally: + signal.alarm(0) wio.close() os.close(r) @@ -3968,6 +3969,7 @@ class SignalsTest(unittest.TestCase): # - third raw read() returns b"bar" self.assertEqual(decode(rio.read(6)), "foobar") finally: + signal.alarm(0) rio.close() os.close(w) os.close(r) @@ -4035,6 +4037,7 @@ class SignalsTest(unittest.TestCase): self.assertIsNone(error) self.assertEqual(N, sum(len(x) for x in read_results)) finally: + signal.alarm(0) write_finished = True os.close(w) os.close(r) |