summaryrefslogtreecommitdiffstats
path: root/Lib/test/test_logging.py
diff options
context:
space:
mode:
authorJouke Witteveen <j.witteveen@gmail.com>2022-03-27 13:49:28 (GMT)
committerGitHub <noreply@github.com>2022-03-27 13:49:28 (GMT)
commit5ca6d7469be53960843df39bb900e9c3359f127f (patch)
tree0a0b96d2c1f2e68f993941833fe87da5f5f2274a /Lib/test/test_logging.py
parent5fd8c574e016aec85725ddc5ced8742267b0e1b3 (diff)
downloadcpython-5ca6d7469be53960843df39bb900e9c3359f127f.zip
cpython-5ca6d7469be53960843df39bb900e9c3359f127f.tar.gz
cpython-5ca6d7469be53960843df39bb900e9c3359f127f.tar.bz2
bpo-45171: Fix stacklevel handling in logging. (GH-28287)
Diffstat (limited to 'Lib/test/test_logging.py')
-rw-r--r--Lib/test/test_logging.py13
1 files changed, 12 insertions, 1 deletions
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 5f72a6d..00e3541 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -5050,9 +5050,10 @@ class LoggerTest(BaseTest, AssertErrorMessage):
def test_find_caller_with_stacklevel(self):
the_level = 1
+ trigger = self.logger.warning
def innermost():
- self.logger.warning('test', stacklevel=the_level)
+ trigger('test', stacklevel=the_level)
def inner():
innermost()
@@ -5074,6 +5075,16 @@ class LoggerTest(BaseTest, AssertErrorMessage):
self.assertEqual(records[-1].funcName, 'outer')
self.assertGreater(records[-1].lineno, lineno)
lineno = records[-1].lineno
+ trigger = self.logger.warn
+ outer()
+ self.assertEqual(records[-1].funcName, 'outer')
+ root_logger = logging.getLogger()
+ root_logger.addHandler(self.recording)
+ trigger = logging.warning
+ outer()
+ self.assertEqual(records[-1].funcName, 'outer')
+ root_logger.removeHandler(self.recording)
+ trigger = self.logger.warning
the_level += 1
outer()
self.assertEqual(records[-1].funcName, 'test_find_caller_with_stacklevel')