summaryrefslogtreecommitdiffstats
path: root/Lib/test/test_normalization.py
diff options
context:
space:
mode:
authorMariatta <Mariatta@users.noreply.github.com>2017-06-19 11:22:54 (GMT)
committerVictor Stinner <victor.stinner@gmail.com>2017-06-19 11:22:54 (GMT)
commit51f40a81a4acbc85cb1034750fb16cb1854b2315 (patch)
treebf3f7dbda0f7f5995eaf56983ebae04bfd4b0f50 /Lib/test/test_normalization.py
parentccc06d32708157b6712808309faf52ceaf7c2870 (diff)
downloadcpython-51f40a81a4acbc85cb1034750fb16cb1854b2315.zip
cpython-51f40a81a4acbc85cb1034750fb16cb1854b2315.tar.gz
cpython-51f40a81a4acbc85cb1034750fb16cb1854b2315.tar.bz2
[3.6] bpo-29887: Test normalization now fails if download fails (GH-905) (#2271)
* test_normalization fails if download fails bpo-29887. The test is still skipped if "-u urlfetch" option is not passed to regrtest (python3 -m test -u urlfetch test_normalization). * Fix ResourceWarning in test_normalization bpo-29887: Fix ResourceWarning in test_normalization if tests are interrupted by CTRL+c. (cherry picked from commit 722a3af092b94983aa26f5e591fb1b45e2c2a0ff)
Diffstat (limited to 'Lib/test/test_normalization.py')
-rw-r--r--Lib/test/test_normalization.py13
1 files changed, 9 insertions, 4 deletions
diff --git a/Lib/test/test_normalization.py b/Lib/test/test_normalization.py
index 5b590e1..c6f8c93 100644
--- a/Lib/test/test_normalization.py
+++ b/Lib/test/test_normalization.py
@@ -36,15 +36,20 @@ def unistr(data):
class NormalizationTest(unittest.TestCase):
def test_main(self):
- part = None
- part1_data = {}
# Hit the exception early
try:
testdata = open_urlresource(TESTDATAURL, encoding="utf-8",
check=check_version)
except (OSError, HTTPException):
- self.skipTest("Could not retrieve " + TESTDATAURL)
- self.addCleanup(testdata.close)
+ self.fail(f"Could not retrieve {TESTDATAURL}")
+
+ with testdata:
+ self.run_normalization_tests(testdata)
+
+ def run_normalization_tests(self, testdata):
+ part = None
+ part1_data = {}
+
for line in testdata:
if '#' in line:
line = line.split('#')[0]