diff options
| author | Barney Gale <barney.gale@gmail.com> | 2024-01-27 19:59:51 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-27 19:59:51 (GMT) |
| commit | 823a38a960c245cbf309ef29120d3690ba1bcd2c (patch) | |
| tree | 71d67154b8df245aa6256a2fb45a20254f743048 /Lib/test/test_pathlib/test_pathlib_abc.py | |
| parent | 7a470541e2bbc6f3e87a6d813e2ec42cf726de7a (diff) | |
| download | cpython-823a38a960c245cbf309ef29120d3690ba1bcd2c.zip cpython-823a38a960c245cbf309ef29120d3690ba1bcd2c.tar.gz cpython-823a38a960c245cbf309ef29120d3690ba1bcd2c.tar.bz2 | |
GH-79634: Speed up pathlib globbing by removing `joinpath()` call. (#114623)
Remove `self.joinpath('')` call that should have been removed in 6313cdde.
This makes `PathBase.glob('')` yield itself *without* adding a trailing slash. It's hard to say whether this is more or less correct, but at least everything else is faster, and there's no behaviour change in the public classes where empty glob patterns are disallowed.
Diffstat (limited to 'Lib/test/test_pathlib/test_pathlib_abc.py')
| -rw-r--r-- | Lib/test/test_pathlib/test_pathlib_abc.py | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/Lib/test/test_pathlib/test_pathlib_abc.py b/Lib/test/test_pathlib/test_pathlib_abc.py index ea70931..ab989cb 100644 --- a/Lib/test/test_pathlib/test_pathlib_abc.py +++ b/Lib/test/test_pathlib/test_pathlib_abc.py @@ -1733,12 +1733,11 @@ class DummyPathTest(DummyPurePathTest): self.assertEqual(set(map(str, p.glob("F*a"))), {f"{p}\\fileA"}) def test_glob_empty_pattern(self): - def _check(glob, expected): - self.assertEqual(set(glob), { P(self.base, q) for q in expected }) P = self.cls p = P(self.base) - _check(p.glob(""), [""]) - _check(p.glob("."), ["."]) + self.assertEqual(list(p.glob("")), [p]) + self.assertEqual(list(p.glob(".")), [p / "."]) + self.assertEqual(list(p.glob("./")), [p / "./"]) def test_glob_case_sensitive(self): P = self.cls |