diff options
author | Ronald Oussoren <ronaldoussoren@mac.com> | 2020-10-19 18:13:49 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-10-19 18:13:49 (GMT) |
commit | 05ee790f4d1cd8725a90b54268fc1dfe5b4d1fa2 (patch) | |
tree | 58e7bd477ec641a442c50424f6a5acc7d792957c /Lib/test/test_plistlib.py | |
parent | 985f0ab3ad5e8e9a8d7fc53026c38390b1f2b466 (diff) | |
download | cpython-05ee790f4d1cd8725a90b54268fc1dfe5b4d1fa2.zip cpython-05ee790f4d1cd8725a90b54268fc1dfe5b4d1fa2.tar.gz cpython-05ee790f4d1cd8725a90b54268fc1dfe5b4d1fa2.tar.bz2 |
bpo-42051: Reject XML entity declarations in plist files (#22760)
Diffstat (limited to 'Lib/test/test_plistlib.py')
-rw-r--r-- | Lib/test/test_plistlib.py | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/Lib/test/test_plistlib.py b/Lib/test/test_plistlib.py index e5c9b5b..cb071da 100644 --- a/Lib/test/test_plistlib.py +++ b/Lib/test/test_plistlib.py @@ -106,6 +106,19 @@ TESTDATA={ AAABOQ=='''), } +XML_PLIST_WITH_ENTITY=b'''\ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd" [ + <!ENTITY entity "replacement text"> + ]> +<plist version="1.0"> + <dict> + <key>A</key> + <string>&entity;</string> + </dict> +</plist> +''' + class TestPlistlib(unittest.TestCase): @@ -524,6 +537,11 @@ class TestPlistlib(unittest.TestCase): with self.assertRaises(OverflowError): plistlib.dumps(huge_uid, fmt=plistlib.FMT_BINARY) + def test_xml_plist_with_entity_decl(self): + with self.assertRaisesRegex(plistlib.InvalidFileException, + "XML entity declarations are not supported"): + plistlib.loads(XML_PLIST_WITH_ENTITY, fmt=plistlib.FMT_XML) + class TestBinaryPlistlib(unittest.TestCase): |