diff options
| author | Gregory P. Smith <greg@krypto.org> | 2017-09-09 07:30:15 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-09-09 07:30:15 (GMT) |
| commit | efb1d0a3c001a6153211063ba439b9847aa03509 (patch) | |
| tree | fdfc7187242eb8db236c5b2445b73c61e88b429f /Lib/test/test_smtpd.py | |
| parent | 829dacce4fca60fc3c3367980e75e21dfcdbe6be (diff) | |
| download | cpython-efb1d0a3c001a6153211063ba439b9847aa03509.zip cpython-efb1d0a3c001a6153211063ba439b9847aa03509.tar.gz cpython-efb1d0a3c001a6153211063ba439b9847aa03509.tar.bz2 | |
bpo-29639: change test.support.HOST to "localhost"
test.support.HOST should be "localhost" as it was in the past. See the bpo-29639.
Tests that need the IP address should use HOSTv4 (added) or the existing HOSTv6 constant.
This changes the definition and fixes tests that needed updating to deal with HOST being
the hostname rather than the hardcoded IP address.
This is only the first step in addressing https://bugs.python.org/issue29639.
Diffstat (limited to 'Lib/test/test_smtpd.py')
| -rw-r--r-- | Lib/test/test_smtpd.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Lib/test/test_smtpd.py b/Lib/test/test_smtpd.py index 3eebe94..a9f7d5a 100644 --- a/Lib/test/test_smtpd.py +++ b/Lib/test/test_smtpd.py @@ -170,11 +170,11 @@ class TestFamilyDetection(unittest.TestCase): @unittest.skipUnless(support.IPV6_ENABLED, "IPv6 not enabled") def test_socket_uses_IPv6(self): - server = smtpd.SMTPServer((support.HOSTv6, 0), (support.HOST, 0)) + server = smtpd.SMTPServer((support.HOSTv6, 0), (support.HOSTv4, 0)) self.assertEqual(server.socket.family, socket.AF_INET6) def test_socket_uses_IPv4(self): - server = smtpd.SMTPServer((support.HOST, 0), (support.HOSTv6, 0)) + server = smtpd.SMTPServer((support.HOSTv4, 0), (support.HOSTv6, 0)) self.assertEqual(server.socket.family, socket.AF_INET) |