diff options
| author | Giampaolo Rodola' <g.rodola@gmail.com> | 2013-04-10 13:49:47 (GMT) |
|---|---|---|
| committer | Giampaolo Rodola' <g.rodola@gmail.com> | 2013-04-10 13:49:47 (GMT) |
| commit | 50331cbf0894bd18d8c89669297776153036bbbb (patch) | |
| tree | b30a7b38583fb157f604a03450a7ecabddac4cc7 /Lib/test/test_socket.py | |
| parent | 7d36e4f074a0141966394284f877bbe2270ccd93 (diff) | |
| download | cpython-50331cbf0894bd18d8c89669297776153036bbbb.zip cpython-50331cbf0894bd18d8c89669297776153036bbbb.tar.gz cpython-50331cbf0894bd18d8c89669297776153036bbbb.tar.bz2 | |
Fix issue #17675: make socket repr() provide local and remote addresses (if any).
Diffstat (limited to 'Lib/test/test_socket.py')
| -rw-r--r-- | Lib/test/test_socket.py | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py index ec76671..9b6d184 100644 --- a/Lib/test/test_socket.py +++ b/Lib/test/test_socket.py @@ -652,8 +652,17 @@ class GeneralModuleTests(unittest.TestCase): def test_repr(self): s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) - self.addCleanup(s.close) - self.assertTrue(repr(s).startswith("<socket.socket object")) + with s: + self.assertIn('fd=%i' % s.fileno(), repr(s)) + self.assertIn('family=%i' % socket.AF_INET, repr(s)) + self.assertIn('type=%i' % socket.SOCK_STREAM, repr(s)) + self.assertIn('proto=0', repr(s)) + self.assertIn('laddr', repr(s)) + self.assertNotIn('raddr', repr(s)) + s.bind(('127.0.0.1', 0)) + self.assertIn(str(s.getsockname()), repr(s)) + self.assertIn('[closed]', repr(s)) + self.assertNotIn('laddr', repr(s)) def test_weakref(self): s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) |