diff options
| author | Charles-François Natali <cf.natali@gmail.com> | 2014-10-13 18:19:26 (GMT) |
|---|---|---|
| committer | Charles-François Natali <cf.natali@gmail.com> | 2014-10-13 18:19:26 (GMT) |
| commit | 0f4f048fa5ff06438a4624bc1dc02aa458a79748 (patch) | |
| tree | 26aa0625a57f2e7d49c3c93a9a7c30d3b9d4f631 /Lib/test/test_socketserver.py | |
| parent | efc7258377e79cff0ea41f97fa999873325e2fb5 (diff) | |
| download | cpython-0f4f048fa5ff06438a4624bc1dc02aa458a79748.zip cpython-0f4f048fa5ff06438a4624bc1dc02aa458a79748.tar.gz cpython-0f4f048fa5ff06438a4624bc1dc02aa458a79748.tar.bz2 | |
Issue #22435: Fix a file descriptor leak when SocketServer bind fails.
Diffstat (limited to 'Lib/test/test_socketserver.py')
| -rw-r--r-- | Lib/test/test_socketserver.py | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/Lib/test/test_socketserver.py b/Lib/test/test_socketserver.py index 0617b30..0276f99 100644 --- a/Lib/test/test_socketserver.py +++ b/Lib/test/test_socketserver.py @@ -302,6 +302,16 @@ class SocketServerTest(unittest.TestCase): t.join() s.server_close() + def test_tcpserver_bind_leak(self): + # Issue #22435: the server socket wouldn't be closed if bind()/listen() + # failed. + # Create many servers for which bind() will fail, to see if this result + # in FD exhaustion. + for i in range(1024): + with self.assertRaises(OverflowError): + socketserver.TCPServer((HOST, -1), + socketserver.StreamRequestHandler) + def test_main(): if imp.lock_held(): |