diff options
author | Gregory P. Smith <greg@krypto.org> | 2013-12-01 03:02:57 (GMT) |
---|---|---|
committer | Gregory P. Smith <greg@krypto.org> | 2013-12-01 03:02:57 (GMT) |
commit | 1eda9e7c3074bfe37674c8140b3d02bf94caf4f3 (patch) | |
tree | 66e0ccc1c1d085cfdfb6335f07b48e57dac0d4e2 /Lib/test/test_subprocess.py | |
parent | 65846c6c5190a92446176f318fd837c6005cfa29 (diff) | |
download | cpython-1eda9e7c3074bfe37674c8140b3d02bf94caf4f3.zip cpython-1eda9e7c3074bfe37674c8140b3d02bf94caf4f3.tar.gz cpython-1eda9e7c3074bfe37674c8140b3d02bf94caf4f3.tar.bz2 |
Fixes Issue #15798 - subprocess.Popen() no longer fails if file
descriptor 0, 1 or 2 is closed.
Diffstat (limited to 'Lib/test/test_subprocess.py')
-rw-r--r-- | Lib/test/test_subprocess.py | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py index 77f1ba3..f5a70a3 100644 --- a/Lib/test/test_subprocess.py +++ b/Lib/test/test_subprocess.py @@ -1559,6 +1559,27 @@ class POSIXProcessTestCase(BaseTestCase): # all standard fds closed. self.check_close_std_fds([0, 1, 2]) + def test_small_errpipe_write_fd(self): + """Issue #15798: Popen should work when stdio fds are available.""" + new_stdin = os.dup(0) + new_stdout = os.dup(1) + try: + os.close(0) + os.close(1) + + # Side test: if errpipe_write fails to have its CLOEXEC + # flag set this should cause the parent to think the exec + # failed. Extremely unlikely: everyone supports CLOEXEC. + subprocess.Popen([ + sys.executable, "-c", + "print('AssertionError:0:CLOEXEC failure.')"]).wait() + finally: + # Restore original stdin and stdout + os.dup2(new_stdin, 0) + os.dup2(new_stdout, 1) + os.close(new_stdin) + os.close(new_stdout) + def test_remapping_std_fds(self): # open up some temporary files temps = [mkstemp() for i in range(3)] |