diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2019-03-05 08:06:26 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-03-05 08:06:26 (GMT) |
| commit | 5b10b9824780b2181158902067912ee9e7b04657 (patch) | |
| tree | 1c89bea944e6638eb008c8f106b2ee48cc9448d1 /Lib/test/test_threading.py | |
| parent | 9e4861f52349011cd5916eef8e8344575e8ac426 (diff) | |
| download | cpython-5b10b9824780b2181158902067912ee9e7b04657.zip cpython-5b10b9824780b2181158902067912ee9e7b04657.tar.gz cpython-5b10b9824780b2181158902067912ee9e7b04657.tar.bz2 | |
bpo-22831: Use "with" to avoid possible fd leaks in tests (part 2). (GH-10929)
Diffstat (limited to 'Lib/test/test_threading.py')
| -rw-r--r-- | Lib/test/test_threading.py | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py index af2d6b5..2ddc77b 100644 --- a/Lib/test/test_threading.py +++ b/Lib/test/test_threading.py @@ -788,13 +788,11 @@ class ThreadJoinOnShutdown(BaseTestCase): def random_io(): '''Loop for a while sleeping random tiny amounts and doing some I/O.''' while True: - in_f = open(os.__file__, 'rb') - stuff = in_f.read(200) - null_f = open(os.devnull, 'wb') - null_f.write(stuff) - time.sleep(random.random() / 1995) - null_f.close() - in_f.close() + with open(os.__file__, 'rb') as in_f: + stuff = in_f.read(200) + with open(os.devnull, 'wb') as null_f: + null_f.write(stuff) + time.sleep(random.random() / 1995) thread_has_run.add(threading.current_thread()) def main(): |