diff options
| author | Victor Stinner <victor.stinner@gmail.com> | 2017-09-19 16:36:54 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-09-19 16:36:54 (GMT) |
| commit | 9abee722d448c1c00c7d4e11ce242ec7b13e5c49 (patch) | |
| tree | 52af3dbb3ff6a4a8e28be76f43ef7d4df31deec6 /Lib/test/test_threadsignals.py | |
| parent | a92941ff12c1d554f42c05ed24621894a758b40f (diff) | |
| download | cpython-9abee722d448c1c00c7d4e11ce242ec7b13e5c49.zip cpython-9abee722d448c1c00c7d4e11ce242ec7b13e5c49.tar.gz cpython-9abee722d448c1c00c7d4e11ce242ec7b13e5c49.tar.bz2 | |
bpo-31479: Always reset the signal alarm in tests (#3588)
* bpo-31479: Always reset the signal alarm in tests
Use "try: ... finally: signal.signal(0)" pattern to make sure that
tests don't "leak" a pending fatal signal alarm.
* Move two more alarm() calls into the try block
Fix also typo: replace signal.signal(0) with signal.alarm(0)
* Move another signal.alarm() into the try block
Diffstat (limited to 'Lib/test/test_threadsignals.py')
| -rw-r--r-- | Lib/test/test_threadsignals.py | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/Lib/test/test_threadsignals.py b/Lib/test/test_threadsignals.py index 67a1c58..1ad6c63 100644 --- a/Lib/test/test_threadsignals.py +++ b/Lib/test/test_threadsignals.py @@ -56,9 +56,11 @@ class ThreadSignals(unittest.TestCase): # wait for it return. if signal_blackboard[signal.SIGUSR1]['tripped'] == 0 \ or signal_blackboard[signal.SIGUSR2]['tripped'] == 0: - signal.alarm(1) - signal.pause() - signal.alarm(0) + try: + signal.alarm(1) + signal.pause() + finally: + signal.alarm(0) self.assertEqual( signal_blackboard[signal.SIGUSR1]['tripped'], 1) self.assertEqual( signal_blackboard[signal.SIGUSR1]['tripped_by'], @@ -98,6 +100,7 @@ class ThreadSignals(unittest.TestCase): # after timeout return of lock.acquire() (which can fool assertRaises). self.assertLess(dt, 3.0) finally: + signal.alarm(0) signal.signal(signal.SIGALRM, oldalrm) @unittest.skipIf(USING_PTHREAD_COND, @@ -131,6 +134,7 @@ class ThreadSignals(unittest.TestCase): # See rationale above in test_lock_acquire_interruption self.assertLess(dt, 3.0) finally: + signal.alarm(0) signal.signal(signal.SIGALRM, oldalrm) def acquire_retries_on_intr(self, lock): |