summaryrefslogtreecommitdiffstats
path: root/Lib/test/test_urllib2.py
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2014-02-08 12:51:10 (GMT)
committerSerhiy Storchaka <storchaka@gmail.com>2014-02-08 12:51:10 (GMT)
commitd3e1207191dcb84a58706a5101177f36c09c5681 (patch)
treedd8bafcf64e4b1fa8bdf65f21f44a2d04fc89861 /Lib/test/test_urllib2.py
parent6c9678e1a5651bbaa2bfa31d564f2117033fd494 (diff)
parent25d8aeac7c1e24df79c18f6391b7e42b873d66d8 (diff)
downloadcpython-d3e1207191dcb84a58706a5101177f36c09c5681.zip
cpython-d3e1207191dcb84a58706a5101177f36c09c5681.tar.gz
cpython-d3e1207191dcb84a58706a5101177f36c09c5681.tar.bz2
Issue #20555: Use specific asserts in urllib, httplib, ftplib, cgi, wsgiref tests.
Diffstat (limited to 'Lib/test/test_urllib2.py')
-rw-r--r--Lib/test/test_urllib2.py7
1 files changed, 4 insertions, 3 deletions
diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py
index dbd1c60..b32b409 100644
--- a/Lib/test/test_urllib2.py
+++ b/Lib/test/test_urllib2.py
@@ -603,8 +603,8 @@ class OpenerDirectorTests(unittest.TestCase):
self.assertIsInstance(args[0], Request)
# response from opener.open is None, because there's no
# handler that defines http_open to handle it
- self.assertTrue(args[1] is None or
- isinstance(args[1], MockResponse))
+ if args[1] is not None:
+ self.assertIsInstance(args[1], MockResponse)
def sanepathname2url(path):
try:
@@ -1018,7 +1018,8 @@ class HandlerTests(unittest.TestCase):
MockHeaders({"location": to_url}))
except urllib.error.HTTPError:
# 307 in response to POST requires user OK
- self.assertTrue(code == 307 and data is not None)
+ self.assertEqual(code, 307)
+ self.assertIsNotNone(data)
self.assertEqual(o.req.get_full_url(), to_url)
try:
self.assertEqual(o.req.get_method(), "GET")