diff options
author | Martin Panter <vadmium+py@gmail.com> | 2016-04-09 14:03:17 (GMT) |
---|---|---|
committer | Martin Panter <vadmium+py@gmail.com> | 2016-04-09 14:03:17 (GMT) |
commit | d979b2cfcf4047b8f9b46e169cfa071e80e30d71 (patch) | |
tree | 516753703f0bb53c954c420320e74ac15026107b /Lib/test/test_urllibnet.py | |
parent | fc475a9fa6712b707867802df6072232562a3bd9 (diff) | |
download | cpython-d979b2cfcf4047b8f9b46e169cfa071e80e30d71.zip cpython-d979b2cfcf4047b8f9b46e169cfa071e80e30d71.tar.gz cpython-d979b2cfcf4047b8f9b46e169cfa071e80e30d71.tar.bz2 |
Issue #21069: Move test_fileno() from test_urllibnet and rewrite it
* No longer attempts to close already freed socket file descriptor
* Use socket object to be compatible with Windows
* Do not use a timeout to avoid complication with non-blocking mode
* Use internal localhost server rather than depending on a third party
* Avoid trouble with buffered HTTP data by testing tunnelled CONNECT data
Diffstat (limited to 'Lib/test/test_urllibnet.py')
-rw-r--r-- | Lib/test/test_urllibnet.py | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/Lib/test/test_urllibnet.py b/Lib/test/test_urllibnet.py index d5110a6..f6df54e 100644 --- a/Lib/test/test_urllibnet.py +++ b/Lib/test/test_urllibnet.py @@ -99,17 +99,6 @@ class urlopenNetworkTests(unittest.TestCase): open_url.close() self.assertEqual(code, 404) - # On Windows, socket handles are not file descriptors; this - # test can't pass on Windows. - @unittest.skipIf(sys.platform in ('win32',), 'not appropriate for Windows') - def test_fileno(self): - # Make sure fd returned by fileno is valid. - with self.urlopen("http://www.google.com/") as open_url: - fd = open_url.fileno() - with os.fdopen(fd, 'rb') as f: - self.assertTrue(f.read(), "reading from file created using fd " - "returned by fileno failed") - def test_bad_address(self): # Make sure proper exception is raised when connecting to a bogus # address. |