summaryrefslogtreecommitdiffstats
path: root/Lib/test/test_wait3.py
diff options
context:
space:
mode:
authorVictor Stinner <vstinner@python.org>2019-12-11 10:30:03 (GMT)
committerGitHub <noreply@github.com>2019-12-11 10:30:03 (GMT)
commit0d63bacefd2e5b937ec6b0ec3053777c09941b4a (patch)
tree638bde819a554379c8c5aff31ba8d6a1feeb1db1 /Lib/test/test_wait3.py
parentb7a0109cd2bafaa21a4d50aad307e901c68f9156 (diff)
downloadcpython-0d63bacefd2e5b937ec6b0ec3053777c09941b4a.zip
cpython-0d63bacefd2e5b937ec6b0ec3053777c09941b4a.tar.gz
cpython-0d63bacefd2e5b937ec6b0ec3053777c09941b4a.tar.bz2
bpo-38614: Use test.support.SHORT_TIMEOUT constant (GH-17566)
Replace hardcoded timeout constants in tests with SHORT_TIMEOUT of test.support, so it's easier to ajdust this timeout for all tests at once. SHORT_TIMEOUT is 30 seconds by default, but it can be longer depending on --timeout command line option. The change makes almost all timeouts longer, except test_reap_children() of test_support which is made 2x shorter: SHORT_TIMEOUT should be enough. If this test starts to fail, LONG_TIMEOUT should be used instead. Uniformize also "from test import support" import in some test files.
Diffstat (limited to 'Lib/test/test_wait3.py')
-rw-r--r--Lib/test/test_wait3.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/Lib/test/test_wait3.py b/Lib/test/test_wait3.py
index 3825451..2dc63aa 100644
--- a/Lib/test/test_wait3.py
+++ b/Lib/test/test_wait3.py
@@ -7,7 +7,7 @@ import sys
import time
import unittest
from test.fork_wait import ForkWait
-from test.support import reap_children
+from test import support
if not hasattr(os, 'fork'):
raise unittest.SkipTest("os.fork not defined")
@@ -20,7 +20,7 @@ class Wait3Test(ForkWait):
# This many iterations can be required, since some previously run
# tests (e.g. test_ctypes) could have spawned a lot of children
# very quickly.
- deadline = time.monotonic() + 10.0
+ deadline = time.monotonic() + support.SHORT_TIMEOUT
while time.monotonic() <= deadline:
# wait3() shouldn't hang, but some of the buildbots seem to hang
# in the forking tests. This is an attempt to fix the problem.
@@ -50,7 +50,7 @@ class Wait3Test(ForkWait):
def tearDownModule():
- reap_children()
+ support.reap_children()
if __name__ == "__main__":
unittest.main()