diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2019-03-05 08:06:26 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-03-05 08:06:26 (GMT) |
| commit | 5b10b9824780b2181158902067912ee9e7b04657 (patch) | |
| tree | 1c89bea944e6638eb008c8f106b2ee48cc9448d1 /Lib/test/test_xmlrpc.py | |
| parent | 9e4861f52349011cd5916eef8e8344575e8ac426 (diff) | |
| download | cpython-5b10b9824780b2181158902067912ee9e7b04657.zip cpython-5b10b9824780b2181158902067912ee9e7b04657.tar.gz cpython-5b10b9824780b2181158902067912ee9e7b04657.tar.bz2 | |
bpo-22831: Use "with" to avoid possible fd leaks in tests (part 2). (GH-10929)
Diffstat (limited to 'Lib/test/test_xmlrpc.py')
| -rw-r--r-- | Lib/test/test_xmlrpc.py | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/Lib/test/test_xmlrpc.py b/Lib/test/test_xmlrpc.py index 916e9c4..9c8b695 100644 --- a/Lib/test/test_xmlrpc.py +++ b/Lib/test/test_xmlrpc.py @@ -821,10 +821,9 @@ class SimpleServerTestCase(BaseServerTestCase): def test_404(self): # send POST with http.client, it should return 404 header and # 'Not Found' message. - conn = http.client.HTTPConnection(ADDR, PORT) - conn.request('POST', '/this-is-not-valid') - response = conn.getresponse() - conn.close() + with contextlib.closing(http.client.HTTPConnection(ADDR, PORT)) as conn: + conn.request('POST', '/this-is-not-valid') + response = conn.getresponse() self.assertEqual(response.status, 404) self.assertEqual(response.reason, 'Not Found') @@ -944,9 +943,8 @@ class SimpleServerTestCase(BaseServerTestCase): def test_partial_post(self): # Check that a partial POST doesn't make the server loop: issue #14001. - conn = http.client.HTTPConnection(ADDR, PORT) - conn.request('POST', '/RPC2 HTTP/1.0\r\nContent-Length: 100\r\n\r\nbye') - conn.close() + with contextlib.closing(http.client.HTTPConnection(ADDR, PORT)) as conn: + conn.request('POST', '/RPC2 HTTP/1.0\r\nContent-Length: 100\r\n\r\nbye') def test_context_manager(self): with xmlrpclib.ServerProxy(URL) as server: |