diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2019-03-05 08:06:26 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-03-05 08:06:26 (GMT) |
| commit | 5b10b9824780b2181158902067912ee9e7b04657 (patch) | |
| tree | 1c89bea944e6638eb008c8f106b2ee48cc9448d1 /Lib/test/test_zipimport_support.py | |
| parent | 9e4861f52349011cd5916eef8e8344575e8ac426 (diff) | |
| download | cpython-5b10b9824780b2181158902067912ee9e7b04657.zip cpython-5b10b9824780b2181158902067912ee9e7b04657.tar.gz cpython-5b10b9824780b2181158902067912ee9e7b04657.tar.bz2 | |
bpo-22831: Use "with" to avoid possible fd leaks in tests (part 2). (GH-10929)
Diffstat (limited to 'Lib/test/test_zipimport_support.py')
| -rw-r--r-- | Lib/test/test_zipimport_support.py | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/Lib/test/test_zipimport_support.py b/Lib/test/test_zipimport_support.py index 84d526c..8856101 100644 --- a/Lib/test/test_zipimport_support.py +++ b/Lib/test/test_zipimport_support.py @@ -122,15 +122,13 @@ class ZipSupportTests(unittest.TestCase): test_src) zip_name, run_name = make_zip_script(d, 'test_zip', script_name) - z = zipfile.ZipFile(zip_name, 'a') - for mod_name, src in sample_sources.items(): - z.writestr(mod_name + ".py", src) - z.close() + with zipfile.ZipFile(zip_name, 'a') as z: + for mod_name, src in sample_sources.items(): + z.writestr(mod_name + ".py", src) if verbose: - zip_file = zipfile.ZipFile(zip_name, 'r') - print ('Contents of %r:' % zip_name) - zip_file.printdir() - zip_file.close() + with zipfile.ZipFile(zip_name, 'r') as zip_file: + print ('Contents of %r:' % zip_name) + zip_file.printdir() os.remove(script_name) sys.path.insert(0, zip_name) import test_zipped_doctest |