diff options
| author | Skip Montanaro <skip@pobox.com> | 2005-12-30 05:09:48 (GMT) |
|---|---|---|
| committer | Skip Montanaro <skip@pobox.com> | 2005-12-30 05:09:48 (GMT) |
| commit | 39b29be8a6639212402303adab4df29976d8fc7c (patch) | |
| tree | 39ec5c719125381f6898668ba36f1090334359d0 /Lib/test | |
| parent | 0174dddc65af50900324afca3c5d2400858b75f0 (diff) | |
| download | cpython-39b29be8a6639212402303adab4df29976d8fc7c.zip cpython-39b29be8a6639212402303adab4df29976d8fc7c.tar.gz cpython-39b29be8a6639212402303adab4df29976d8fc7c.tar.bz2 | |
Fix a delimiter detection problem in sniffer. Sniffing "a|b|c\r\n" was
returning 'a' as the delimiter. It now returns '|', but not because I
understood better what the code was supposed to do. Would someone that
understands the idea behind _guess_delimiter() (see its doc string) look to
see if my fallback choice is better than before or if it's just serendipity
that I picked the proper delimiter?
Diffstat (limited to 'Lib/test')
| -rw-r--r-- | Lib/test/test_csv.py | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/Lib/test/test_csv.py b/Lib/test/test_csv.py index 0ad77ef..8511a5a 100644 --- a/Lib/test/test_csv.py +++ b/Lib/test/test_csv.py @@ -852,6 +852,8 @@ Stonecutters Seafood and Chop House, Lemont, IL, 12/19/02, Week Back ''' sample5 = "aaa\tbbb\r\nAAA\t\r\nBBB\t\r\n" + sample6 = "a|b|c\r\nd|e|f\r\n" + sample7 = "'a'|'b'|'c'\r\n'd'|e|f\r\n" def test_has_header(self): sniffer = csv.Sniffer() @@ -882,6 +884,11 @@ Stonecutters Seafood and Chop House, Lemont, IL, 12/19/02, Week Back self.assertEqual(dialect.delimiter, ";") dialect = sniffer.sniff(self.sample5) self.assertEqual(dialect.delimiter, "\t") + dialect = sniffer.sniff(self.sample6) + self.assertEqual(dialect.delimiter, "|") + dialect = sniffer.sniff(self.sample7) + self.assertEqual(dialect.delimiter, "|") + self.assertEqual(dialect.quotechar, "'") if not hasattr(sys, "gettotalrefcount"): if test_support.verbose: print "*** skipping leakage tests ***" |