summaryrefslogtreecommitdiffstats
path: root/Lib/test
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2020-09-22 13:16:46 (GMT)
committerGitHub <noreply@github.com>2020-09-22 13:16:46 (GMT)
commit557b9a52edc4445cec293f2cc2c268c4f564adcf (patch)
treedc197fd8a194d1eb5fb31eb6f12736efa09ff7e7 /Lib/test
parentc5cb077ab3c88394b7ac8ed4e746bd31b53e39f1 (diff)
downloadcpython-557b9a52edc4445cec293f2cc2c268c4f564adcf.zip
cpython-557b9a52edc4445cec293f2cc2c268c4f564adcf.tar.gz
cpython-557b9a52edc4445cec293f2cc2c268c4f564adcf.tar.bz2
bpo-40670: More reliable validation of statements in timeit.Timer. (GH-22358)
It now accepts "empty" statements (only whitespaces and comments) and rejects misindentent statements.
Diffstat (limited to 'Lib/test')
-rw-r--r--Lib/test/test_timeit.py9
1 files changed, 9 insertions, 0 deletions
diff --git a/Lib/test/test_timeit.py b/Lib/test/test_timeit.py
index e02d4a7..72a104f 100644
--- a/Lib/test/test_timeit.py
+++ b/Lib/test/test_timeit.py
@@ -77,6 +77,9 @@ class TestTimeit(unittest.TestCase):
self.assertRaises(SyntaxError, timeit.Timer, stmt='break')
self.assertRaises(SyntaxError, timeit.Timer, stmt='continue')
self.assertRaises(SyntaxError, timeit.Timer, stmt='from timeit import *')
+ self.assertRaises(SyntaxError, timeit.Timer, stmt=' pass')
+ self.assertRaises(SyntaxError, timeit.Timer,
+ setup='while False:\n pass', stmt=' break')
def test_timer_invalid_setup(self):
self.assertRaises(ValueError, timeit.Timer, setup=None)
@@ -86,6 +89,12 @@ class TestTimeit(unittest.TestCase):
self.assertRaises(SyntaxError, timeit.Timer, setup='break')
self.assertRaises(SyntaxError, timeit.Timer, setup='continue')
self.assertRaises(SyntaxError, timeit.Timer, setup='from timeit import *')
+ self.assertRaises(SyntaxError, timeit.Timer, setup=' pass')
+
+ def test_timer_empty_stmt(self):
+ timeit.Timer(stmt='')
+ timeit.Timer(stmt=' \n\t\f')
+ timeit.Timer(stmt='# comment')
fake_setup = "import timeit\ntimeit._fake_timer.setup()"
fake_stmt = "import timeit\ntimeit._fake_timer.inc()"