summaryrefslogtreecommitdiffstats
path: root/Lib/test
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2024-05-14 09:47:11 (GMT)
committerGitHub <noreply@github.com>2024-05-14 09:47:11 (GMT)
commit387ff96e95b9f8a8cc7e646523ba3175b1350669 (patch)
treecf1447b3371a8be5c0d50022a6e8f7708ef8782c /Lib/test
parent5bf7f5c6a874ebb8dfcf35f4868cfa8fd2a6cffe (diff)
downloadcpython-387ff96e95b9f8a8cc7e646523ba3175b1350669.zip
cpython-387ff96e95b9f8a8cc7e646523ba3175b1350669.tar.gz
cpython-387ff96e95b9f8a8cc7e646523ba3175b1350669.tar.bz2
[3.12] gh-67693: Fix urlunparse() and urlunsplit() for URIs with path starting with multiple slashes and no authority (GH-113563) (GH-119024)
(cherry picked from commit e237b25a4fa5626fcd1b1848aa03f725f892e40e) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Diffstat (limited to 'Lib/test')
-rw-r--r--Lib/test/test_urlparse.py70
1 files changed, 67 insertions, 3 deletions
diff --git a/Lib/test/test_urlparse.py b/Lib/test/test_urlparse.py
index 236b6e4..2cf03d0 100644
--- a/Lib/test/test_urlparse.py
+++ b/Lib/test/test_urlparse.py
@@ -103,7 +103,9 @@ parse_qs_test_cases = [
class UrlParseTestCase(unittest.TestCase):
- def checkRoundtrips(self, url, parsed, split):
+ def checkRoundtrips(self, url, parsed, split, url2=None):
+ if url2 is None:
+ url2 = url
result = urllib.parse.urlparse(url)
self.assertSequenceEqual(result, parsed)
t = (result.scheme, result.netloc, result.path,
@@ -111,7 +113,7 @@ class UrlParseTestCase(unittest.TestCase):
self.assertSequenceEqual(t, parsed)
# put it back together and it should be the same
result2 = urllib.parse.urlunparse(result)
- self.assertSequenceEqual(result2, url)
+ self.assertSequenceEqual(result2, url2)
self.assertSequenceEqual(result2, result.geturl())
# the result of geturl() is a fixpoint; we can always parse it
@@ -137,7 +139,7 @@ class UrlParseTestCase(unittest.TestCase):
result.query, result.fragment)
self.assertSequenceEqual(t, split)
result2 = urllib.parse.urlunsplit(result)
- self.assertSequenceEqual(result2, url)
+ self.assertSequenceEqual(result2, url2)
self.assertSequenceEqual(result2, result.geturl())
# check the fixpoint property of re-parsing the result of geturl()
@@ -175,9 +177,39 @@ class UrlParseTestCase(unittest.TestCase):
def test_roundtrips(self):
str_cases = [
+ ('path/to/file',
+ ('', '', 'path/to/file', '', '', ''),
+ ('', '', 'path/to/file', '', '')),
+ ('/path/to/file',
+ ('', '', '/path/to/file', '', '', ''),
+ ('', '', '/path/to/file', '', '')),
+ ('//path/to/file',
+ ('', 'path', '/to/file', '', '', ''),
+ ('', 'path', '/to/file', '', '')),
+ ('////path/to/file',
+ ('', '', '//path/to/file', '', '', ''),
+ ('', '', '//path/to/file', '', '')),
+ ('scheme:path/to/file',
+ ('scheme', '', 'path/to/file', '', '', ''),
+ ('scheme', '', 'path/to/file', '', '')),
+ ('scheme:/path/to/file',
+ ('scheme', '', '/path/to/file', '', '', ''),
+ ('scheme', '', '/path/to/file', '', '')),
+ ('scheme://path/to/file',
+ ('scheme', 'path', '/to/file', '', '', ''),
+ ('scheme', 'path', '/to/file', '', '')),
+ ('scheme:////path/to/file',
+ ('scheme', '', '//path/to/file', '', '', ''),
+ ('scheme', '', '//path/to/file', '', '')),
('file:///tmp/junk.txt',
('file', '', '/tmp/junk.txt', '', '', ''),
('file', '', '/tmp/junk.txt', '', '')),
+ ('file:////tmp/junk.txt',
+ ('file', '', '//tmp/junk.txt', '', '', ''),
+ ('file', '', '//tmp/junk.txt', '', '')),
+ ('file://///tmp/junk.txt',
+ ('file', '', '///tmp/junk.txt', '', '', ''),
+ ('file', '', '///tmp/junk.txt', '', '')),
('imap://mail.python.org/mbox1',
('imap', 'mail.python.org', '/mbox1', '', '', ''),
('imap', 'mail.python.org', '/mbox1', '', '')),
@@ -213,6 +245,38 @@ class UrlParseTestCase(unittest.TestCase):
for url, parsed, split in str_cases + bytes_cases:
self.checkRoundtrips(url, parsed, split)
+ def test_roundtrips_normalization(self):
+ str_cases = [
+ ('///path/to/file',
+ '/path/to/file',
+ ('', '', '/path/to/file', '', '', ''),
+ ('', '', '/path/to/file', '', '')),
+ ('scheme:///path/to/file',
+ 'scheme:/path/to/file',
+ ('scheme', '', '/path/to/file', '', '', ''),
+ ('scheme', '', '/path/to/file', '', '')),
+ ('file:/tmp/junk.txt',
+ 'file:///tmp/junk.txt',
+ ('file', '', '/tmp/junk.txt', '', '', ''),
+ ('file', '', '/tmp/junk.txt', '', '')),
+ ('http:/tmp/junk.txt',
+ 'http:///tmp/junk.txt',
+ ('http', '', '/tmp/junk.txt', '', '', ''),
+ ('http', '', '/tmp/junk.txt', '', '')),
+ ('https:/tmp/junk.txt',
+ 'https:///tmp/junk.txt',
+ ('https', '', '/tmp/junk.txt', '', '', ''),
+ ('https', '', '/tmp/junk.txt', '', '')),
+ ]
+ def _encode(t):
+ return (t[0].encode('ascii'),
+ t[1].encode('ascii'),
+ tuple(x.encode('ascii') for x in t[2]),
+ tuple(x.encode('ascii') for x in t[3]))
+ bytes_cases = [_encode(x) for x in str_cases]
+ for url, url2, parsed, split in str_cases + bytes_cases:
+ self.checkRoundtrips(url, parsed, split, url2)
+
def test_http_roundtrips(self):
# urllib.parse.urlsplit treats 'http:' as an optimized special case,
# so we test both 'http:' and 'https:' in all the following.