summaryrefslogtreecommitdiffstats
path: root/Lib/test
diff options
context:
space:
mode:
authorArtem Bulgakov <ArtemSBulgakov@ya.ru>2020-09-07 16:46:33 (GMT)
committerGitHub <noreply@github.com>2020-09-07 16:46:33 (GMT)
commit22748a83d927d3da1beaed771be30887c42b2500 (patch)
tree7bd2922fc537fd2af5c629a089e091eaa993325d /Lib/test
parentfd4cafd4700dc03cb05fc2e5263c2666d785d6e3 (diff)
downloadcpython-22748a83d927d3da1beaed771be30887c42b2500.zip
cpython-22748a83d927d3da1beaed771be30887c42b2500.tar.gz
cpython-22748a83d927d3da1beaed771be30887c42b2500.tar.bz2
bpo-41316: Make tarfile follow specs for FNAME (GH-21511)
tarfile writes full path to FNAME field of GZIP format instead of just basename if user specified absolute path. Some archive viewers may process file incorrectly. Also it creates security issue because anyone can know structure of directories on system and know username or other personal information. RFC1952 says about FNAME: This is the original name of the file being compressed, with any directory components removed. So tarfile must remove directory names from FNAME and write only basename of file. Automerge-Triggered-By: @jaraco
Diffstat (limited to 'Lib/test')
-rw-r--r--Lib/test/test_tarfile.py14
1 files changed, 13 insertions, 1 deletions
diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py
index 4ef20db..7b34d53 100644
--- a/Lib/test/test_tarfile.py
+++ b/Lib/test/test_tarfile.py
@@ -1417,12 +1417,15 @@ class WriteTest(WriteTestBase, unittest.TestCase):
pax_headers={'non': 'empty'})
self.assertFalse(f.closed)
+
class GzipWriteTest(GzipTest, WriteTest):
pass
+
class Bz2WriteTest(Bz2Test, WriteTest):
pass
+
class LzmaWriteTest(LzmaTest, WriteTest):
pass
@@ -1465,8 +1468,17 @@ class StreamWriteTest(WriteTestBase, unittest.TestCase):
finally:
os.umask(original_umask)
+
class GzipStreamWriteTest(GzipTest, StreamWriteTest):
- pass
+ def test_source_directory_not_leaked(self):
+ """
+ Ensure the source directory is not included in the tar header
+ per bpo-41316.
+ """
+ tarfile.open(tmpname, self.mode).close()
+ payload = pathlib.Path(tmpname).read_text(encoding='latin-1')
+ assert os.path.dirname(tmpname) not in payload
+
class Bz2StreamWriteTest(Bz2Test, StreamWriteTest):
decompressor = bz2.BZ2Decompressor if bz2 else None