summaryrefslogtreecommitdiffstats
path: root/Lib/test
diff options
context:
space:
mode:
authorZachary Ware <zach@python.org>2023-10-15 18:34:28 (GMT)
committerGitHub <noreply@github.com>2023-10-15 18:34:28 (GMT)
commitb75186f69edcf54615910a5cd707996144163ef7 (patch)
tree350a82b1b972b01856558a3d7c6d2b60498596f9 /Lib/test
parent42a5d21d465ffcac792685b6127a6e8e39dd6897 (diff)
downloadcpython-b75186f69edcf54615910a5cd707996144163ef7.zip
cpython-b75186f69edcf54615910a5cd707996144163ef7.tar.gz
cpython-b75186f69edcf54615910a5cd707996144163ef7.tar.bz2
regrtest: Prepend 'use' options in --{fast,slow}-ci (GH-110363)
This allows individual resources to be disabled without having to explicitly re-enable all others.
Diffstat (limited to 'Lib/test')
-rw-r--r--Lib/test/libregrtest/cmdline.py10
-rw-r--r--Lib/test/test_regrtest.py8
2 files changed, 11 insertions, 7 deletions
diff --git a/Lib/test/libregrtest/cmdline.py b/Lib/test/libregrtest/cmdline.py
index 5a01f1d..152b558 100644
--- a/Lib/test/libregrtest/cmdline.py
+++ b/Lib/test/libregrtest/cmdline.py
@@ -417,14 +417,16 @@ def _parse_args(args, **kwargs):
# --slow-ci has the priority
if ns.slow_ci:
# Similar to: -u "all" --timeout=1200
- if not ns.use:
- ns.use = [['all']]
+ if ns.use is None:
+ ns.use = []
+ ns.use.insert(0, ['all'])
if ns.timeout is None:
ns.timeout = 1200 # 20 minutes
elif ns.fast_ci:
# Similar to: -u "all,-cpu" --timeout=600
- if not ns.use:
- ns.use = [['all', '-cpu']]
+ if ns.use is None:
+ ns.use = []
+ ns.use.insert(0, ['all', '-cpu'])
if ns.timeout is None:
ns.timeout = 600 # 10 minutes
diff --git a/Lib/test/test_regrtest.py b/Lib/test/test_regrtest.py
index 26c0a67..e65d9a8 100644
--- a/Lib/test/test_regrtest.py
+++ b/Lib/test/test_regrtest.py
@@ -415,9 +415,11 @@ class ParseArgsTestCase(unittest.TestCase):
self.assertEqual(regrtest.python_cmd, ('python', '-X', 'dev'))
def test_fast_ci_resource(self):
- # it should be possible to override resources
- args = ['--fast-ci', '-u', 'network']
- use_resources = ['network']
+ # it should be possible to override resources individually
+ args = ['--fast-ci', '-u-network']
+ use_resources = sorted(cmdline.ALL_RESOURCES)
+ use_resources.remove('cpu')
+ use_resources.remove('network')
self.check_ci_mode(args, use_resources)
def test_slow_ci(self):