diff options
author | Raymond Hettinger <python@rcn.com> | 2002-08-09 01:37:06 (GMT) |
---|---|---|
committer | Raymond Hettinger <python@rcn.com> | 2002-08-09 01:37:06 (GMT) |
commit | c35491ee3a0f3999791de83e65ef94994058ac5e (patch) | |
tree | eb74cd0ee121ab16cae10271641729da8b28d629 /Lib/test | |
parent | 48923c5533865173894bb4b1d8f9851430f49f8b (diff) | |
download | cpython-c35491ee3a0f3999791de83e65ef94994058ac5e.zip cpython-c35491ee3a0f3999791de83e65ef94994058ac5e.tar.gz cpython-c35491ee3a0f3999791de83e65ef94994058ac5e.tar.bz2 |
Moved inplace add and multiply methods from UserString to MutableString.
Closes SF Bug #592573 where inplace add mutated a UserString.
Added unittests to verify the bug is cleared.
Diffstat (limited to 'Lib/test')
-rw-r--r-- | Lib/test/string_tests.py | 6 | ||||
-rw-r--r-- | Lib/test/test_string.py | 1 | ||||
-rwxr-xr-x | Lib/test/test_userstring.py | 1 |
3 files changed, 8 insertions, 0 deletions
diff --git a/Lib/test/string_tests.py b/Lib/test/string_tests.py index 1729999..a071f20 100644 --- a/Lib/test/string_tests.py +++ b/Lib/test/string_tests.py @@ -314,3 +314,9 @@ def run_contains_tests(test): test('__contains__', 'asdf', True, 'asdf') # vereq('asdf' in 'asdf', True) test('__contains__', 'asd', False, 'asdf') # vereq('asdf' in 'asd', False) test('__contains__', '', False, 'asdf') # vereq('asdf' in '', False) + +def run_inplace_tests(constructor): + # Verify clearing of SF bug #592573 + s = t = constructor('abc') + s += constructor('def') + verify(s != t, 'in-place concatenate should create a new object') diff --git a/Lib/test/test_string.py b/Lib/test/test_string.py index c92f5f7..a30cdbd 100644 --- a/Lib/test/test_string.py +++ b/Lib/test/test_string.py @@ -52,6 +52,7 @@ def test(name, input, output, *args): string_tests.run_module_tests(test) string_tests.run_method_tests(test) string_tests.run_contains_tests(test) +string_tests.run_inplace_tests(str) string.whitespace string.lowercase diff --git a/Lib/test/test_userstring.py b/Lib/test/test_userstring.py index 5492f2e..67fbb5c 100755 --- a/Lib/test/test_userstring.py +++ b/Lib/test/test_userstring.py @@ -42,3 +42,4 @@ def test(methodname, input, output, *args): string_tests.run_method_tests(test) string_tests.run_contains_tests(test) +string_tests.run_inplace_tests(UserString) |