diff options
author | Benjamin Peterson <benjamin@python.org> | 2017-09-11 06:50:46 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-09-11 06:50:46 (GMT) |
commit | 2bb69a5b4e7f96cb35d1b28aa7b7b3974b351f59 (patch) | |
tree | b7f672d07435aff1060d27f20867365e637b8df9 /Lib/test | |
parent | 252033d50effa08046ac34fcc406bc99796ab88b (diff) | |
download | cpython-2bb69a5b4e7f96cb35d1b28aa7b7b3974b351f59.zip cpython-2bb69a5b4e7f96cb35d1b28aa7b7b3974b351f59.tar.gz cpython-2bb69a5b4e7f96cb35d1b28aa7b7b3974b351f59.tar.bz2 |
bpo-31373: remove overly strict float range checks (#3486)
This undoes a853a8ba7850381d49b284295dd6f0dc491dbe44 except for the pytime.c
parts. We want to continue to allow IEEE 754 doubles larger than FLT_MAX to be
rounded into finite floats. Tests were added to very this behavior.
Diffstat (limited to 'Lib/test')
-rw-r--r-- | Lib/test/test_float.py | 6 | ||||
-rw-r--r-- | Lib/test/test_getargs2.py | 6 |
2 files changed, 12 insertions, 0 deletions
diff --git a/Lib/test/test_float.py b/Lib/test/test_float.py index 66726d6..a16c05c 100644 --- a/Lib/test/test_float.py +++ b/Lib/test/test_float.py @@ -617,6 +617,12 @@ class IEEEFormatTestCase(unittest.TestCase): ('<f', LE_FLOAT_NAN)]: struct.unpack(fmt, data) + @support.requires_IEEE_754 + def test_serialized_float_rounding(self): + from _testcapi import FLT_MAX + self.assertEqual(struct.pack("<f", 3.40282356e38), struct.pack("<f", FLT_MAX)) + self.assertEqual(struct.pack("<f", -3.40282356e38), struct.pack("<f", -FLT_MAX)) + class FormatTestCase(unittest.TestCase): def test_format(self): diff --git a/Lib/test/test_getargs2.py b/Lib/test/test_getargs2.py index 86df3a4..20f6f4d 100644 --- a/Lib/test/test_getargs2.py +++ b/Lib/test/test_getargs2.py @@ -377,6 +377,12 @@ class Float_TestCase(unittest.TestCase): r = getargs_f(NAN) self.assertNotEqual(r, r) + @support.requires_IEEE_754 + def test_f_rounding(self): + from _testcapi import getargs_f + self.assertEqual(getargs_f(3.40282356e38), FLT_MAX) + self.assertEqual(getargs_f(-3.40282356e38), -FLT_MAX) + def test_d(self): from _testcapi import getargs_d self.assertEqual(getargs_d(4.25), 4.25) |