summaryrefslogtreecommitdiffstats
path: root/Lib/threading.py
diff options
context:
space:
mode:
authorVictor Stinner <vstinner@python.org>2020-11-16 14:20:34 (GMT)
committerGitHub <noreply@github.com>2020-11-16 14:20:34 (GMT)
commit5909a494cd3ba43143b28bd439773ed85a485dfc (patch)
tree0b56888e59bd79cc18ade15404f231d6d700e551 /Lib/threading.py
parent3df5c68487df9d1d20ab0cd06e7942a4f96d40a4 (diff)
downloadcpython-5909a494cd3ba43143b28bd439773ed85a485dfc.zip
cpython-5909a494cd3ba43143b28bd439773ed85a485dfc.tar.gz
cpython-5909a494cd3ba43143b28bd439773ed85a485dfc.tar.bz2
bpo-42350: Fix Thread._reset_internal_locks() (GH-23268)
Fix the threading.Thread class at fork: do nothing if the thread is already stopped (ex: fork called at Python exit). Previously, an error was logged in the child process.
Diffstat (limited to 'Lib/threading.py')
-rw-r--r--Lib/threading.py8
1 files changed, 6 insertions, 2 deletions
diff --git a/Lib/threading.py b/Lib/threading.py
index 7dae77d..7b3d63d 100644
--- a/Lib/threading.py
+++ b/Lib/threading.py
@@ -844,8 +844,12 @@ class Thread:
# they may be in an invalid state leading to a deadlock or crash.
self._started._at_fork_reinit()
if is_alive:
- self._tstate_lock._at_fork_reinit()
- self._tstate_lock.acquire()
+ # bpo-42350: If the fork happens when the thread is already stopped
+ # (ex: after threading._shutdown() has been called), _tstate_lock
+ # is None. Do nothing in this case.
+ if self._tstate_lock is not None:
+ self._tstate_lock._at_fork_reinit()
+ self._tstate_lock.acquire()
else:
# The thread isn't alive after fork: it doesn't have a tstate
# anymore.