diff options
| author | Tim Peters <tim@python.org> | 2013-10-09 01:55:51 (GMT) |
|---|---|---|
| committer | Tim Peters <tim@python.org> | 2013-10-09 01:55:51 (GMT) |
| commit | 7634e1cf9028ed5b21f0a97db45c91d8e8a159a6 (patch) | |
| tree | ad1fe9e98197bb607b5e833df4df62c34e75937e /Lib/threading.py | |
| parent | ee82d0b29355df56744962b51563f24c4d2a6102 (diff) | |
| download | cpython-7634e1cf9028ed5b21f0a97db45c91d8e8a159a6.zip cpython-7634e1cf9028ed5b21f0a97db45c91d8e8a159a6.tar.gz cpython-7634e1cf9028ed5b21f0a97db45c91d8e8a159a6.tar.bz2 | |
Issue 19158: a rare race in BoundedSemaphore could allow .release() too often.
Diffstat (limited to 'Lib/threading.py')
| -rw-r--r-- | Lib/threading.py | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/Lib/threading.py b/Lib/threading.py index c98a006..3d4952b 100644 --- a/Lib/threading.py +++ b/Lib/threading.py @@ -283,9 +283,11 @@ class BoundedSemaphore(Semaphore): self._initial_value = value def release(self): - if self._value >= self._initial_value: - raise ValueError("Semaphore released too many times") - return Semaphore.release(self) + with self._cond: + if self._value >= self._initial_value: + raise ValueError("Semaphore released too many times") + self._value += 1 + self._cond.notify() class Event: |