diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2020-12-19 10:17:08 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-12-19 10:17:08 (GMT) |
| commit | 3d569fd6dccf9f582bafaca04d3535094cae393e (patch) | |
| tree | 2468e1823c476391b2abecc79d093e0cbeb96b0c /Lib/tkinter/commondialog.py | |
| parent | 1e27b57dbc8c1b758e37a531487813aef2d111ca (diff) | |
| download | cpython-3d569fd6dccf9f582bafaca04d3535094cae393e.zip cpython-3d569fd6dccf9f582bafaca04d3535094cae393e.tar.gz cpython-3d569fd6dccf9f582bafaca04d3535094cae393e.tar.bz2 | |
bpo-42630: Improve error reporting in Tkinter for absent default root (GH-23781)
* Tkinter functions and constructors which need a default root window
raise now RuntimeError with descriptive message instead of obscure
AttributeError or NameError if it is not created yet or cannot
be created automatically.
* Add tests for all functions which use default root window.
* Fix import in the pynche script.
Diffstat (limited to 'Lib/tkinter/commondialog.py')
| -rw-r--r-- | Lib/tkinter/commondialog.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Lib/tkinter/commondialog.py b/Lib/tkinter/commondialog.py index e56b5ba..cc30698 100644 --- a/Lib/tkinter/commondialog.py +++ b/Lib/tkinter/commondialog.py @@ -18,10 +18,10 @@ class Dialog: command = None def __init__(self, master=None, **options): + if not master: + master = options.get('parent') self.master = master self.options = options - if not master and options.get('parent'): - self.master = options['parent'] def _fixoptions(self): pass # hook |