diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2022-12-04 20:06:42 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-04 20:06:42 (GMT) |
| commit | 9bcc68b045fd06af3896d15d6375fa4d96b706cc (patch) | |
| tree | 4bf24b3f4d734d9c50dd3fc29368d8c1b10110de /Lib/unittest/result.py | |
| parent | 7aa87bba056c9c548812a82cefbd122c67c71b88 (diff) | |
| download | cpython-9bcc68b045fd06af3896d15d6375fa4d96b706cc.zip cpython-9bcc68b045fd06af3896d15d6375fa4d96b706cc.tar.gz cpython-9bcc68b045fd06af3896d15d6375fa4d96b706cc.tar.bz2 | |
gh-98458: unittest: bugfix for infinite loop while handling chained exceptions that contain cycles (GH-98459)
* Bugfix addressing infinite loop while handling self-referencing chained exception in TestResult._clean_tracebacks()
* Bugfix extended to properly handle exception cycles in _clean_tracebacks. The "seen" set follows the approach used in the TracebackException class (thank you @iritkatriel for pointing it out)
* adds a test for a single chained exception that holds a self-loop in its __cause__ and __context__ attributes
(cherry picked from commit 72ec518203c3f3577a5e888b12f10bb49060e6c2)
Co-authored-by: AlexTate <0xalextate@gmail.com>
Diffstat (limited to 'Lib/unittest/result.py')
| -rw-r--r-- | Lib/unittest/result.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/Lib/unittest/result.py b/Lib/unittest/result.py index 3da7005..5ca4c23 100644 --- a/Lib/unittest/result.py +++ b/Lib/unittest/result.py @@ -196,6 +196,7 @@ class TestResult(object): ret = None first = True excs = [(exctype, value, tb)] + seen = {id(value)} # Detect loops in chained exceptions. while excs: (exctype, value, tb) = excs.pop() # Skip test runner traceback levels @@ -214,8 +215,9 @@ class TestResult(object): if value is not None: for c in (value.__cause__, value.__context__): - if c is not None: + if c is not None and id(c) not in seen: excs.append((type(c), c, c.__traceback__)) + seen.add(id(c)) return ret def _is_relevant_tb_level(self, tb): |