summaryrefslogtreecommitdiffstats
path: root/Lib/unittest/suite.py
diff options
context:
space:
mode:
authorMichael Foord <fuzzyman@voidspace.org.uk>2010-11-01 21:09:03 (GMT)
committerMichael Foord <fuzzyman@voidspace.org.uk>2010-11-01 21:09:03 (GMT)
commitbbea35f194c6a2a64ce96526bd5eee37a75e8c0a (patch)
tree81ff5627203744ca6f12ab8d104520c58f249df4 /Lib/unittest/suite.py
parente6fa3811f7eaca03e022c28717878c3c5b22db66 (diff)
downloadcpython-bbea35f194c6a2a64ce96526bd5eee37a75e8c0a.zip
cpython-bbea35f194c6a2a64ce96526bd5eee37a75e8c0a.tar.gz
cpython-bbea35f194c6a2a64ce96526bd5eee37a75e8c0a.tar.bz2
Fix issue 9926. TestSuite subclasses that override __call__ are called correctly.
Diffstat (limited to 'Lib/unittest/suite.py')
-rw-r--r--Lib/unittest/suite.py36
1 files changed, 17 insertions, 19 deletions
diff --git a/Lib/unittest/suite.py b/Lib/unittest/suite.py
index b6ae68c..73f0e17 100644
--- a/Lib/unittest/suite.py
+++ b/Lib/unittest/suite.py
@@ -77,23 +77,11 @@ class TestSuite(BaseTestSuite):
subclassing, do not forget to call the base class constructor.
"""
+ def run(self, result, debug=False):
+ topLevel = False
+ if getattr(result, '_testRunEntered', False) is False:
+ result._testRunEntered = topLevel = True
- def run(self, result):
- self._wrapped_run(result)
- self._tearDownPreviousClass(None, result)
- self._handleModuleTearDown(result)
- return result
-
- def debug(self):
- """Run the tests without collecting errors in a TestResult"""
- debug = _DebugResult()
- self._wrapped_run(debug, True)
- self._tearDownPreviousClass(None, debug)
- self._handleModuleTearDown(debug)
-
- ################################
- # private methods
- def _wrapped_run(self, result, debug=False):
for test in self:
if result.shouldStop:
break
@@ -108,13 +96,23 @@ class TestSuite(BaseTestSuite):
getattr(result, '_moduleSetUpFailed', False)):
continue
- if hasattr(test, '_wrapped_run'):
- test._wrapped_run(result, debug)
- elif not debug:
+ if not debug:
test(result)
else:
test.debug()
+ if topLevel:
+ self._tearDownPreviousClass(None, result)
+ self._handleModuleTearDown(result)
+ return result
+
+ def debug(self):
+ """Run the tests without collecting errors in a TestResult"""
+ debug = _DebugResult()
+ self.run(debug, True)
+
+ ################################
+
def _handleClassSetUp(self, test, result):
previousClass = getattr(result, '_previousTestClass', None)
currentClass = test.__class__