diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2013-11-16 22:12:21 (GMT) |
|---|---|---|
| committer | Serhiy Storchaka <storchaka@gmail.com> | 2013-11-16 22:12:21 (GMT) |
| commit | 5665bc5980cd20252fe1d27807759cecee8594d0 (patch) | |
| tree | 04c09b0879e10aa82e7023d916965206669e8475 /Lib/unittest/test/testmock/testmock.py | |
| parent | 7c5e24f948e6ce33e21b09833f8fe3a8eb1530ac (diff) | |
| download | cpython-5665bc5980cd20252fe1d27807759cecee8594d0.zip cpython-5665bc5980cd20252fe1d27807759cecee8594d0.tar.gz cpython-5665bc5980cd20252fe1d27807759cecee8594d0.tar.bz2 | |
Issue #19594: Use specific asserts in unittest tests.
Diffstat (limited to 'Lib/unittest/test/testmock/testmock.py')
| -rw-r--r-- | Lib/unittest/test/testmock/testmock.py | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/Lib/unittest/test/testmock/testmock.py b/Lib/unittest/test/testmock/testmock.py index 3d0776c..cef5405 100644 --- a/Lib/unittest/test/testmock/testmock.py +++ b/Lib/unittest/test/testmock/testmock.py @@ -52,7 +52,7 @@ class MockTest(unittest.TestCase): "method_calls not initialised correctly") # Can't use hasattr for this test as it always returns True on a mock - self.assertFalse('_items' in mock.__dict__, + self.assertNotIn('_items', mock.__dict__, "default mock should not have '_items' attribute") self.assertIsNone(mock._mock_parent, @@ -493,19 +493,19 @@ class MockTest(unittest.TestCase): pass mock = Mock(spec=X) - self.assertTrue(isinstance(mock, X)) + self.assertIsInstance(mock, X) mock = Mock(spec=X()) - self.assertTrue(isinstance(mock, X)) + self.assertIsInstance(mock, X) self.assertIs(mock.__class__, X) self.assertEqual(Mock().__class__.__name__, 'Mock') mock = Mock(spec_set=X) - self.assertTrue(isinstance(mock, X)) + self.assertIsInstance(mock, X) mock = Mock(spec_set=X()) - self.assertTrue(isinstance(mock, X)) + self.assertIsInstance(mock, X) def test_setting_attribute_with_spec_set(self): |